-
Notifications
You must be signed in to change notification settings - Fork 116
chore: optimise post analytics query #3256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Empty file.
19 changes: 19 additions & 0 deletions
19
clickhouse/migrations/20251104112214_post_analytics_events_mv.up.sql
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| ALTER TABLE api.post_analytics_events_mv | ||
| MODIFY QUERY | ||
| SELECT target_id AS post_id, | ||
| sumIf(toUInt64(1), event_name = 'share post') AS shares_external, | ||
| sumIf(toUInt64(1), event_name = 'share to squad') AS shares_internal, | ||
| uniqStateIf(user_id, event_name = 'bookmark post') AS bookmarks, | ||
| sumIf(toUInt64(1), (event_name = 'impression') AND (target_type = 'post')) AS impressions, | ||
| uniqStateIf(user_id, (event_name = 'impression') AND (target_type = 'post')) AS reach, | ||
| uniqStateIf(user_id, (event_name = 'impression') AND (target_type = 'post')) AS reach_all, | ||
| sumIf(toUInt64(1), (event_name = 'click') AND (target_type = 'post')) AS clicks, | ||
| sumIf(toUInt64(1), (event_name = 'go to link') AND (target_type = 'post')) AS go_to_link, | ||
| max(server_timestamp) AS created_at | ||
| FROM events.raw_events | ||
| WHERE (event_name IN ('share post', 'bookmark post', 'impression', 'share to squad', 'click', 'go to link')) | ||
| AND (target_id IS NOT NULL) | ||
| AND (target_type = 'post') | ||
| AND (server_timestamp > '2025-10-08 13:00:00') | ||
| GROUP BY target_id | ||
| SETTINGS materialized_views_ignore_errors = 1; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this hard coded date?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it was there and I haven't changed it.
idea of specifying the date/timestamp is to cut the time when MV begins working, so you can manually backfill the data before this timestamp.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've only added
AND (target_type = 'post')There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah really hate you can't see actual diffs on these migrations :(