feat: add feedback option to opportunity#3262
Merged
rebelchris merged 2 commits intomainfrom Nov 7, 2025
Merged
Conversation
|
🍹 The Update (preview) for dailydotdev/api/prod (at 6454aeb) was successful. Resource Changes Name Type Operation
~ vpc-native-check-analytics-report-cron kubernetes:batch/v1:CronJob update
~ vpc-native-validate-active-users-cron kubernetes:batch/v1:CronJob update
~ vpc-native-calculate-top-readers-cron kubernetes:batch/v1:CronJob update
~ vpc-native-update-source-public-threshold-cron kubernetes:batch/v1:CronJob update
~ vpc-native-deployment kubernetes:apps/v1:Deployment update
~ vpc-native-bg-deployment kubernetes:apps/v1:Deployment update
~ vpc-native-temporal-deployment kubernetes:apps/v1:Deployment update
- vpc-native-api-db-migration-7cba0404 kubernetes:batch/v1:Job delete
~ vpc-native-daily-digest-cron kubernetes:batch/v1:CronJob update
+ vpc-native-api-clickhouse-migration-b64ad136 kubernetes:batch/v1:Job create
~ vpc-native-post-analytics-history-day-clickhouse-cron kubernetes:batch/v1:CronJob update
~ vpc-native-post-analytics-clickhouse-cron kubernetes:batch/v1:CronJob update
~ vpc-native-update-current-streak-cron kubernetes:batch/v1:CronJob update
+ vpc-native-api-db-migration-b64ad136 kubernetes:batch/v1:Job create
~ vpc-native-ws-deployment kubernetes:apps/v1:Deployment update
~ vpc-native-update-tags-str-cron kubernetes:batch/v1:CronJob update
~ vpc-native-sync-subscription-with-cio-cron kubernetes:batch/v1:CronJob update
~ vpc-native-clean-zombie-users-cron kubernetes:batch/v1:CronJob update
~ vpc-native-private-deployment kubernetes:apps/v1:Deployment update
~ vpc-native-hourly-notification-cron kubernetes:batch/v1:CronJob update
~ vpc-native-personalized-digest-cron kubernetes:batch/v1:CronJob update
~ vpc-native-personalized-digest-deployment kubernetes:apps/v1:Deployment update
~ vpc-native-clean-zombie-images-cron kubernetes:batch/v1:CronJob update
~ vpc-native-generic-referral-reminder-cron kubernetes:batch/v1:CronJob update
~ vpc-native-generate-search-invites-cron kubernetes:batch/v1:CronJob update
~ vpc-native-update-highlighted-views-cron kubernetes:batch/v1:CronJob update
~ vpc-native-clean-stale-user-transactions-cron kubernetes:batch/v1:CronJob update
~ vpc-native-update-trending-cron kubernetes:batch/v1:CronJob update
~ vpc-native-clean-zombie-user-companies-cron kubernetes:batch/v1:CronJob update
~ vpc-native-clean-gifted-plus-cron kubernetes:batch/v1:CronJob update
- vpc-native-api-clickhouse-migration-7cba0404 kubernetes:batch/v1:Job delete
~ vpc-native-update-source-tag-view-cron kubernetes:batch/v1:CronJob update
~ vpc-native-update-views-cron kubernetes:batch/v1:CronJob update
~ vpc-native-update-tag-recommendations-cron kubernetes:batch/v1:CronJob update
|
omBratteng
reviewed
Nov 7, 2025
| .orderBy(`${childAlias}."questionOrder"`, 'ASC'), | ||
| }, | ||
| }, | ||
| feedbackQuestions: { |
Contributor
There was a problem hiding this comment.
not sure if these are needed if you just add the where type to the additionalQuery in OpportunityFeedbackQuestion and OpportunityScreeningQuestion
Contributor
Author
There was a problem hiding this comment.
I also thought that, but those did nothing there and these worked which made the ones there not needed anymore :(
omBratteng
reviewed
Nov 7, 2025
| opportunityId: ID! | ||
| } | ||
|
|
||
| type OpportunityFeedbackQuestion { |
Contributor
There was a problem hiding this comment.
Alternatively, OpportunityScreeningQuestion could be made to a generic OpportunityQuestion to reduce duplication, then in graphorm on fields, you add the extra type selector?
Contributor
Author
There was a problem hiding this comment.
Yeah could also be an option, but guess for now this is ok, as they kinda seperate from loading/storing I guess.
omBratteng
approved these changes
Nov 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds option to add feedback type questions to opportunity (used in rejection flow)