Skip to content

fix: pr feedback#3285

Merged
rebelchris merged 6 commits intomainfrom
fix-pr-feedback
Nov 13, 2025
Merged

fix: pr feedback#3285
rebelchris merged 6 commits intomainfrom
fix-pr-feedback

Conversation

@rebelchris
Copy link
Copy Markdown
Contributor

PR feedback, see frontend changes here:
dailydotdev/apps#5065

Comment thread src/graphorm/index.ts
Comment thread src/schema/opportunity.ts Outdated
@rebelchris rebelchris requested a review from idoshamun November 13, 2025 08:38
@pulumi
Copy link
Copy Markdown

pulumi Bot commented Nov 13, 2025

🍹 The Update (preview) for dailydotdev/api/prod (at 1055ce8) was successful.

Resource Changes

    Name                                                   Type                           Operation
~   vpc-native-daily-digest-cron                           kubernetes:batch/v1:CronJob    update
~   vpc-native-deployment                                  kubernetes:apps/v1:Deployment  update
~   vpc-native-clean-gifted-plus-cron                      kubernetes:batch/v1:CronJob    update
~   vpc-native-check-analytics-report-cron                 kubernetes:batch/v1:CronJob    update
-   vpc-native-api-db-migration-79ddfe35                   kubernetes:batch/v1:Job        delete
~   vpc-native-temporal-deployment                         kubernetes:apps/v1:Deployment  update
~   vpc-native-generate-search-invites-cron                kubernetes:batch/v1:CronJob    update
~   vpc-native-update-trending-cron                        kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-stale-user-transactions-cron          kubernetes:batch/v1:CronJob    update
~   vpc-native-post-analytics-clickhouse-cron              kubernetes:batch/v1:CronJob    update
~   vpc-native-generic-referral-reminder-cron              kubernetes:batch/v1:CronJob    update
+   vpc-native-api-clickhouse-migration-0e7597f0           kubernetes:batch/v1:Job        create
-   vpc-native-api-clickhouse-migration-79ddfe35           kubernetes:batch/v1:Job        delete
~   vpc-native-validate-active-users-cron                  kubernetes:batch/v1:CronJob    update
~   vpc-native-update-highlighted-views-cron               kubernetes:batch/v1:CronJob    update
~   vpc-native-sync-subscription-with-cio-cron             kubernetes:batch/v1:CronJob    update
~   vpc-native-personalized-digest-deployment              kubernetes:apps/v1:Deployment  update
~   vpc-native-update-tags-str-cron                        kubernetes:batch/v1:CronJob    update
+   vpc-native-api-db-migration-0e7597f0                   kubernetes:batch/v1:Job        create
~   vpc-native-personalized-digest-cron                    kubernetes:batch/v1:CronJob    update
~   vpc-native-update-views-cron                           kubernetes:batch/v1:CronJob    update
~   vpc-native-update-tag-recommendations-cron             kubernetes:batch/v1:CronJob    update
~   vpc-native-hourly-notification-cron                    kubernetes:batch/v1:CronJob    update
~   vpc-native-private-deployment                          kubernetes:apps/v1:Deployment  update
~   vpc-native-update-source-tag-view-cron                 kubernetes:batch/v1:CronJob    update
~   vpc-native-update-current-streak-cron                  kubernetes:batch/v1:CronJob    update
~   vpc-native-bg-deployment                               kubernetes:apps/v1:Deployment  update
~   vpc-native-ws-deployment                               kubernetes:apps/v1:Deployment  update
~   vpc-native-post-analytics-history-day-clickhouse-cron  kubernetes:batch/v1:CronJob    update
~   vpc-native-calculate-top-readers-cron                  kubernetes:batch/v1:CronJob    update
~   vpc-native-update-source-public-threshold-cron         kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-zombie-user-companies-cron            kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-zombie-images-cron                    kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-zombie-users-cron                     kubernetes:batch/v1:CronJob    update

Copy link
Copy Markdown
Member

@idoshamun idoshamun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just check my latest comment. it can be another pr if you want but we need to address

@rebelchris rebelchris merged commit b023296 into main Nov 13, 2025
9 checks passed
@rebelchris rebelchris deleted the fix-pr-feedback branch November 13, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants