Skip to content

fix: link experience when company is manually approved #3321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AmarTrebinjac merged 2 commits into from
Dec 22, 2025
Merged

fix: link experience when company is manually approved #3321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f974a26
fix: link experience when company is manually approved
AmarTrebinjac Dec 2, 2025
a82158b
Merge branch 'main' into manual-company-approval
AmarTrebinjac Dec 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
207 changes: 207 additions & 0 deletions __tests__/workers/cdc/primary.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5126,6 +5126,213 @@ describe('user company approved', () => {
expect(experiences.every((exp) => exp.verified)).toBe(true);
});
});

describe('links experiences by customCompanyName', () => {
beforeEach(async () => {
await saveFixtures(con, User, usersFixture);
await con.getRepository(Company).save({
id: 'comp1',
name: 'Test Company',
altName: 'Test Alt Name',
image: 'https://example.com/image.png',
domains: ['testcompany.com'],
createdAt: new Date(),
updatedAt: new Date(),
});
});

it('should link experience with matching customCompanyName (exact match)', async () => {
const experience = await con.getRepository(UserExperienceWork).save({
userId: '1',
companyId: null,
customCompanyName: 'Test Company',
title: 'Software Engineer',
startedAt: new Date('2020-01-01'),
verified: false,
type: UserExperienceType.Work,
});

const after: ChangeObject<ObjectType> = { ...base, companyId: 'comp1' };
await expectSuccessfulBackground(
worker,
mockChangeMessage<ObjectType>({
after,
before: null,
op: 'c',
table: 'user_company',
}),
);

const updatedExperience = await con
.getRepository(UserExperienceWork)
.findOneBy({ id: experience.id });
expect(updatedExperience?.companyId).toBe('comp1');
});

it('should link experience with matching customCompanyName (case insensitive)', async () => {
const experience = await con.getRepository(UserExperienceWork).save({
userId: '1',
companyId: null,
customCompanyName: 'TEST COMPANY',
title: 'Software Engineer',
startedAt: new Date('2020-01-01'),
verified: false,
type: UserExperienceType.Work,
});

const after: ChangeObject<ObjectType> = { ...base, companyId: 'comp1' };
await expectSuccessfulBackground(
worker,
mockChangeMessage<ObjectType>({
after,
before: null,
op: 'c',
table: 'user_company',
}),
);

const updatedExperience = await con
.getRepository(UserExperienceWork)
.findOneBy({ id: experience.id });
expect(updatedExperience?.companyId).toBe('comp1');
});

it('should link experience with matching altName (case insensitive)', async () => {
const experience = await con.getRepository(UserExperienceWork).save({
userId: '1',
companyId: null,
customCompanyName: 'test alt name',
title: 'Software Engineer',
startedAt: new Date('2020-01-01'),
verified: false,
type: UserExperienceType.Work,
});

const after: ChangeObject<ObjectType> = { ...base, companyId: 'comp1' };
await expectSuccessfulBackground(
worker,
mockChangeMessage<ObjectType>({
after,
before: null,
op: 'c',
table: 'user_company',
}),
);

const updatedExperience = await con
.getRepository(UserExperienceWork)
.findOneBy({ id: experience.id });
expect(updatedExperience?.companyId).toBe('comp1');
});

it('should not link experience with non-matching customCompanyName', async () => {
const experience = await con.getRepository(UserExperienceWork).save({
userId: '1',
companyId: null,
customCompanyName: 'Some Other Company',
title: 'Software Engineer',
startedAt: new Date('2020-01-01'),
verified: false,
type: UserExperienceType.Work,
});

const after: ChangeObject<ObjectType> = { ...base, companyId: 'comp1' };
await expectSuccessfulBackground(
worker,
mockChangeMessage<ObjectType>({
after,
before: null,
op: 'c',
table: 'user_company',
}),
);

const updatedExperience = await con
.getRepository(UserExperienceWork)
.findOneBy({ id: experience.id });
expect(updatedExperience?.companyId).toBeNull();
});

it('should not overwrite experience that already has a companyId', async () => {
await con.getRepository(Company).save({
id: 'comp2',
name: 'Other Company',
image: 'https://example.com/image2.png',
domains: ['othercompany.com'],
createdAt: new Date(),
updatedAt: new Date(),
});

const experience = await con.getRepository(UserExperienceWork).save({
userId: '1',
companyId: 'comp2',
customCompanyName: 'Test Company',
title: 'Software Engineer',
startedAt: new Date('2020-01-01'),
verified: false,
type: UserExperienceType.Work,
});

const after: ChangeObject<ObjectType> = { ...base, companyId: 'comp1' };
await expectSuccessfulBackground(
worker,
mockChangeMessage<ObjectType>({
after,
before: null,
op: 'c',
table: 'user_company',
}),
);

const updatedExperience = await con
.getRepository(UserExperienceWork)
.findOneBy({ id: experience.id });
expect(updatedExperience?.companyId).toBe('comp2');
});

it('should only link experiences for the same user', async () => {
const experience1 = await con.getRepository(UserExperienceWork).save({
userId: '1',
companyId: null,
customCompanyName: 'Test Company',
title: 'Software Engineer',
startedAt: new Date('2020-01-01'),
verified: false,
type: UserExperienceType.Work,
});

const experience2 = await con.getRepository(UserExperienceWork).save({
userId: '2',
companyId: null,
customCompanyName: 'Test Company',
title: 'Software Engineer',
startedAt: new Date('2020-01-01'),
verified: false,
type: UserExperienceType.Work,
});

const after: ChangeObject<ObjectType> = { ...base, companyId: 'comp1' };
await expectSuccessfulBackground(
worker,
mockChangeMessage<ObjectType>({
after,
before: null,
op: 'c',
table: 'user_company',
}),
);

const updatedExperience1 = await con
.getRepository(UserExperienceWork)
.findOneBy({ id: experience1.id });
expect(updatedExperience1?.companyId).toBe('comp1');

const updatedExperience2 = await con
.getRepository(UserExperienceWork)
.findOneBy({ id: experience2.id });
expect(updatedExperience2?.companyId).toBeNull();
});
});
});

describe('bookmark change', () => {
Expand Down
24 changes: 24 additions & 0 deletions src/workers/cdc/primary.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,7 @@ import { UserExperience } from '../../entity/user/experiences/UserExperience';
import { UserExperienceType } from '../../entity/user/experiences/types';
import { cio, identifyUserOpportunities } from '../../cio';
import { enrichCompanyForExperience } from '../../common/companyEnrichment';
import { Company } from '../../entity/Company';

const isFreeformPostLongEnough = (
freeform: ChangeMessage<FreeformPost>,
Expand Down Expand Up @@ -1206,6 +1207,29 @@ const onUserCompanyCompanyChange = async (
await con
.getRepository(UserExperienceWork)
.update({ userId, companyId: companyId! }, { verified: true });

// Link experiences that have matching customCompanyName but no companyId yet
const company = await con
.getRepository(Company)
.findOneBy({ id: companyId! });
if (company) {
const companyNames = [company.name.toLowerCase()];
if (company.altName) {
companyNames.push(company.altName.toLowerCase());
}

await con
.getRepository(UserExperience)
.createQueryBuilder()
.update()
.set({ companyId: companyId! })
.where('userId = :userId', { userId })
.andWhere('companyId IS NULL')
.andWhere('LOWER("customCompanyName") IN (:...companyNames)', {
companyNames,
})
.execute();
}
}
};

Expand Down
Loading