Skip to content

Chore missed type #3334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rebelchris merged 4 commits into from
Dec 9, 2025
Merged

Chore missed type #3334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
eda0960
chore: missed one type
rebelchris Dec 9, 2025
1dc0d4f
fix: add type return whole object
rebelchris Dec 9, 2025
af1e0a2
Merge branch 'main' into chore-missed-type
rebelchris Dec 9, 2025
3e9a998
fix: ensure no dups
rebelchris Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/common/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ export const uniqueifyArray = <T>(array: T[]): T[] => {
return [...new Set(array)];
};

export /**
/**
* Remove duplicate values from an array of objects per unique key
*
* @template T
Expand All @@ -110,7 +110,7 @@ export /**
* @param {(item: T, index: number, uniqueKey: string) => R} [processItem] Optional function to process the item before adding it to the result array
* @return {*} {R[]}
*/
const uniqueifyObjectArray = <T, R = T>(
export const uniqueifyObjectArray = <T, R = T>(
array: T[],
uniqueKey: (item: T) => string,
processItem?: (item: T, index: number, uniqueKey: string) => R,
Expand Down
10 changes: 6 additions & 4 deletions src/schema/opportunity.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import {
getBufferFromStream,
toGQLEnum,
uniqueifyArray,
uniqueifyObjectArray,
updateFlagsStatement,
} from '../common';
import {
Expand Down Expand Up @@ -166,7 +167,7 @@ export interface GQLOpportunityPreviewResult {
totalCount: number;
tags: string[] | null;
companies: Array<{ name: string; favicon?: string }> | null;
squads: string[] | null;
squads: GQLSource[] | null;
}

export interface GQLOpportunityPreviewConnection {
Expand Down Expand Up @@ -463,7 +464,7 @@ export const typeDefs = /* GraphQL */ `
type OpportunityPreviewResult {
tags: [String!]!
companies: [OpportunityPreviewCompany!]!
squads: [String!]!
squads: [Source!]!
totalCount: Int
}

Expand Down Expand Up @@ -1282,10 +1283,11 @@ export const resolvers: IResolvers<unknown, BaseContext> = traceResolvers<

const companies = getShowcaseCompanies();

const squads = uniqueifyArray(
const squads = uniqueifyObjectArray(
connection.edges.flatMap(({ node }) =>
(node.activeSquads || []).map((squad) => squad.id),
(node.activeSquads || []).map((squad) => squad),
),
(squad) => squad.handle,
);

return {
Expand Down
Loading