feat: implement backwards compatibility for social links migration#3427
Merged
feat: implement backwards compatibility for social links migration#3427
Conversation
This commit implements full backwards compatibility for the flexible social links migration, ensuring legacy social field columns continue to work while reading from the new socialLinks JSONB column. Changes: - GraphQL (GraphORM): Added field resolvers for all 13 legacy social fields (twitter, github, linkedin, threads, roadmap, codepen, reddit, stackoverflow, youtube, bluesky, mastodon, hashnode, portfolio) that derive values from socialLinks - Boot endpoint: Updated to read from socialLinks and populate legacy fields for backwards compatibility with older clients (especially browser extension) - Common utilities: Moved extractHandleFromUrl to common/schema/socials.ts for code reuse across GraphQL and boot endpoint - Tests: Added test to verify legacy fields are resolved from socialLinks, updated user fixtures to use socialLinks instead of legacy columns - Dual-write: Maintained existing dual-write logic for mutations to ensure both socialLinks and legacy columns stay in sync when updates occur This ensures the browser extension and other clients can continue using legacy fields while the system internally reads from the new socialLinks column. Legacy columns can be safely dropped in Phase 3 after all clients are updated.
Remove redundant legacy social field columns (twitter, github, hashnode) from user test fixtures. These fields are now derived from socialLinks, so having both creates conflicts and duplicate data. This cleanup ensures tests use socialLinks as the single source of truth.
|
🍹 The Update (preview) for dailydotdev/api/prod (at f8e3e8d) was successful. Resource Changes Name Type Operation
~ vpc-native-generic-referral-reminder-cron kubernetes:batch/v1:CronJob update
~ vpc-native-update-trending-cron kubernetes:batch/v1:CronJob update
~ vpc-native-calculate-top-readers-cron kubernetes:batch/v1:CronJob update
~ vpc-native-sync-subscription-with-cio-cron kubernetes:batch/v1:CronJob update
- vpc-native-api-db-migration-0d618d50 kubernetes:batch/v1:Job delete
~ vpc-native-personalized-digest-deployment kubernetes:apps/v1:Deployment update
~ vpc-native-clean-stale-user-transactions-cron kubernetes:batch/v1:CronJob update
~ vpc-native-deployment kubernetes:apps/v1:Deployment update
~ vpc-native-post-analytics-clickhouse-cron kubernetes:batch/v1:CronJob update
~ vpc-native-update-tags-str-cron kubernetes:batch/v1:CronJob update
~ vpc-native-validate-active-users-cron kubernetes:batch/v1:CronJob update
~ vpc-native-generate-search-invites-cron kubernetes:batch/v1:CronJob update
~ vpc-native-update-tag-recommendations-cron kubernetes:batch/v1:CronJob update
+ vpc-native-api-clickhouse-migration-e457100e kubernetes:batch/v1:Job create
~ vpc-native-personalized-digest-cron kubernetes:batch/v1:CronJob update
~ vpc-native-ws-deployment kubernetes:apps/v1:Deployment update
~ vpc-native-clean-zombie-user-companies-cron kubernetes:batch/v1:CronJob update
~ vpc-native-daily-digest-cron kubernetes:batch/v1:CronJob update
~ vpc-native-check-analytics-report-cron kubernetes:batch/v1:CronJob update
~ vpc-native-clean-gifted-plus-cron kubernetes:batch/v1:CronJob update
~ vpc-native-clean-zombie-users-cron kubernetes:batch/v1:CronJob update
- vpc-native-api-clickhouse-migration-0d618d50 kubernetes:batch/v1:Job delete
~ vpc-native-update-source-tag-view-cron kubernetes:batch/v1:CronJob update
~ vpc-native-bg-deployment kubernetes:apps/v1:Deployment update
~ vpc-native-clean-zombie-opportunities-cron kubernetes:batch/v1:CronJob update
+ vpc-native-api-db-migration-e457100e kubernetes:batch/v1:Job create
~ vpc-native-update-views-cron kubernetes:batch/v1:CronJob update
~ vpc-native-user-profile-updated-sync-cron kubernetes:batch/v1:CronJob update
~ vpc-native-post-analytics-history-day-clickhouse-cron kubernetes:batch/v1:CronJob update
~ vpc-native-update-source-public-threshold-cron kubernetes:batch/v1:CronJob update
~ vpc-native-temporal-deployment kubernetes:apps/v1:Deployment update
~ vpc-native-update-current-streak-cron kubernetes:batch/v1:CronJob update
~ vpc-native-private-deployment kubernetes:apps/v1:Deployment update
~ vpc-native-clean-zombie-images-cron kubernetes:batch/v1:CronJob update
~ vpc-native-update-highlighted-views-cron kubernetes:batch/v1:CronJob update
~ vpc-native-hourly-notification-cron kubernetes:batch/v1:CronJob update
|
Type mismatch - user entity expects string | undefined, not string | null.
…tests - Ensures JSON backward compatibility by explicitly setting null for undefined fields. - Removes duplicate social handle validation tests from the users test suite.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit implements full backwards compatibility for the flexible social links
migration, ensuring legacy social field columns continue to work while reading from
the new socialLinks JSONB column.
Changes:
(twitter, github, linkedin, threads, roadmap, codepen, reddit, stackoverflow,
youtube, bluesky, mastodon, hashnode, portfolio) that derive values from socialLinks
backwards compatibility with older clients (especially browser extension)
code reuse across GraphQL and boot endpoint
user fixtures to use socialLinks instead of legacy columns
socialLinks and legacy columns stay in sync when updates occur
This ensures the browser extension and other clients can continue using legacy fields
while the system internally reads from the new socialLinks column. Legacy columns can
be safely dropped in Phase 3 after all clients are updated.