Skip to content

fix: skip highlight entries in feed service response#3769

Merged
pnvasanth merged 1 commit intomainfrom
fix/skip-highlight-feed-entries
Apr 1, 2026
Merged

fix: skip highlight entries in feed service response#3769
pnvasanth merged 1 commit intomainfrom
fix/skip-highlight-feed-entries

Conversation

@pnvasanth
Copy link
Copy Markdown
Contributor

Summary

  • Filter out feed data items with type: "highlight" before processing in FeedClient.fetchFeed
  • Prevents the new highlight entries (empty post_id) from the feed service from breaking downstream post lookups
  • Companion to dailydotdev/daily-feed#806

Test plan

  • TypeScript type-check passes (no new errors)
  • Verify feed responses with highlights enabled still return correct post data
  • Verify highlight entries are filtered out and don't cause DB lookup failures

@pnvasanth pnvasanth self-assigned this Apr 1, 2026
@pulumi
Copy link
Copy Markdown

pulumi Bot commented Apr 1, 2026

🍹 The Update (preview) for dailydotdev/api/prod (at 5a4dc3c) was successful.

✨ Neo Explanation

This is a standard production code deployment rolling out a new application version across all 7 services and 38 scheduled jobs, accompanied by the routine creation of database and ClickHouse migration jobs for the new release.

Root Cause Analysis

A new version of the API application has been built and is being deployed to production. Every Kubernetes resource is being updated to reference the new container image, replacing the previous version across all deployments, cron jobs, and one-time migration jobs.

Dependency Chain

The new application version cascades uniformly across the entire workload:

  • 7 Deployments (API, background, WebSocket, worker, private, Temporal, personalized digest) are being rolled over to the new image via a standard rolling update.
  • 38 CronJobs are having their image reference updated so the next scheduled execution picks up the new code.
  • 2 migration Jobs (database and ClickHouse) are being replaced: the old migration jobs tied to the previous version are deleted, and new ones for the current version are created. This is the standard pattern for running schema migrations on deploy.

Risk analysis

No stateful resources (databases, storage, persistent volumes) are being modified or deleted. The migration jobs are one-shot Kubernetes Jobs — the old completed jobs are cleaned up and new ones are created for this release, which is expected behavior. Deployments use rolling updates, so there is no anticipated downtime.

Resource Changes

    Name                                                    Type                           Operation
~   vpc-native-rotate-daily-quests-cron                     kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-zombie-user-companies-cron             kubernetes:batch/v1:CronJob    update
~   vpc-native-generic-referral-reminder-cron               kubernetes:batch/v1:CronJob    update
~   vpc-native-personalized-digest-cron                     kubernetes:batch/v1:CronJob    update
~   vpc-native-update-current-streak-cron                   kubernetes:batch/v1:CronJob    update
~   vpc-native-sync-subscription-with-cio-cron              kubernetes:batch/v1:CronJob    update
~   vpc-native-bg-deployment                                kubernetes:apps/v1:Deployment  update
~   vpc-native-update-tags-str-cron                         kubernetes:batch/v1:CronJob    update
~   vpc-native-check-analytics-report-cron                  kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-zombie-images-cron                     kubernetes:batch/v1:CronJob    update
~   vpc-native-update-source-public-threshold-cron          kubernetes:batch/v1:CronJob    update
~   vpc-native-expire-super-agent-trial-cron                kubernetes:batch/v1:CronJob    update
~   vpc-native-update-tag-materialized-views-cron           kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-zombie-users-cron                      kubernetes:batch/v1:CronJob    update
+   vpc-native-api-db-migration-e4867307                    kubernetes:batch/v1:Job        create
~   vpc-native-post-analytics-history-day-clickhouse-cron   kubernetes:batch/v1:CronJob    update
~   vpc-native-rotate-weekly-quests-cron                    kubernetes:batch/v1:CronJob    update
+   vpc-native-api-clickhouse-migration-e4867307            kubernetes:batch/v1:Job        create
~   vpc-native-deployment                                   kubernetes:apps/v1:Deployment  update
-   vpc-native-api-db-migration-a4e304c9                    kubernetes:batch/v1:Job        delete
~   vpc-native-daily-digest-cron                            kubernetes:batch/v1:CronJob    update
~   vpc-native-materialize-monthly-best-post-archives-cron  kubernetes:batch/v1:CronJob    update
~   vpc-native-materialize-yearly-best-post-archives-cron   kubernetes:batch/v1:CronJob    update
~   vpc-native-squad-posts-analytics-refresh-cron           kubernetes:batch/v1:CronJob    update
~   vpc-native-generate-search-invites-cron                 kubernetes:batch/v1:CronJob    update
~   vpc-native-ws-deployment                                kubernetes:apps/v1:Deployment  update
~   vpc-native-user-profile-analytics-clickhouse-cron       kubernetes:batch/v1:CronJob    update
~   vpc-native-post-analytics-clickhouse-cron               kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-expired-better-auth-sessions-cron      kubernetes:batch/v1:CronJob    update
~   vpc-native-update-highlighted-views-cron                kubernetes:batch/v1:CronJob    update
~   vpc-native-update-views-cron                            kubernetes:batch/v1:CronJob    update
-   vpc-native-api-clickhouse-migration-a4e304c9            kubernetes:batch/v1:Job        delete
~   vpc-native-update-achievement-rarity-cron               kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-zombie-opportunities-cron              kubernetes:batch/v1:CronJob    update
~   vpc-native-personalized-digest-deployment               kubernetes:apps/v1:Deployment  update
~   vpc-native-channel-highlights-cron                      kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-channel-highlights-cron                kubernetes:batch/v1:CronJob    update
~   vpc-native-user-profile-updated-sync-cron               kubernetes:batch/v1:CronJob    update
~   vpc-native-hourly-notification-cron                     kubernetes:batch/v1:CronJob    update
~   vpc-native-user-posts-analytics-refresh-cron            kubernetes:batch/v1:CronJob    update
~   vpc-native-update-trending-cron                         kubernetes:batch/v1:CronJob    update
... and 11 other changes

Filter out feed data items with type "highlight" before processing,
so the new highlight entries from the feed service don't break
downstream post lookups.
@pnvasanth pnvasanth force-pushed the fix/skip-highlight-feed-entries branch from f199d0a to 5a4dc3c Compare April 1, 2026 13:33
@pnvasanth pnvasanth merged commit 9f39dff into main Apr 1, 2026
10 checks passed
@pnvasanth pnvasanth deleted the fix/skip-highlight-feed-entries branch April 1, 2026 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant