Skip to content

Use public share fallback for unknown highlights#3776

Merged
idoshamun merged 1 commit intomainfrom
codex/highlight-unknown-share-fallback
Apr 5, 2026
Merged

Use public share fallback for unknown highlights#3776
idoshamun merged 1 commit intomainfrom
codex/highlight-unknown-share-fallback

Conversation

@idoshamun
Copy link
Copy Markdown
Member

Summary

  • replace unknown source highlight candidates with the most-upvoted public share for the same post
  • skip unknown source candidates entirely when no public share exists
  • apply the fallback consistently across live highlights, evaluation history, and candidate filtering

Testing

  • NODE_ENV=test npx jest __tests__/workers/generateChannelHighlight.ts --testEnvironment=node --runInBand
  • pnpm exec eslint __tests__/workers/generateChannelHighlight.ts src/common/channelHighlight/generate.ts src/common/channelHighlight/queries.ts src/common/channelHighlight/stories.ts

Notes

  • the targeted Jest run still reports the existing shutdown warning about a worker process not exiting gracefully after completion

@pulumi
Copy link
Copy Markdown

pulumi Bot commented Apr 5, 2026

🍹 The Update (preview) for dailydotdev/api/prod (at b7678cc) was successful.

✨ Neo Explanation

Routine deployment bumping all services and cron jobs to a new application image, with DB and Clickhouse migration jobs re-created for the new commit. ✅ Low Risk.

This is a standard application deployment rolling out a new code version (d03063d4edeb05dc) across all workloads. Every deployment and cron job gets the updated container image and version label. The two migration Jobs (DB and Clickhouse) are deleted and recreated under the new commit hash — this is the expected pattern for immutable Job names tied to the commit SHA, ensuring migrations run exactly once per release.

The GCP credentials warning on the default_9_12_0 provider is cosmetic and does not affect the Kubernetes resources being deployed.

Resource Changes

    Name                                                   Type                           Operation
+   vpc-native-api-db-migration-edeb05dc                   kubernetes:batch/v1:Job        create
~   vpc-native-validate-active-users-cron                  kubernetes:batch/v1:CronJob    update
~   vpc-native-rotate-daily-quests-cron                    kubernetes:batch/v1:CronJob    update
-   vpc-native-api-db-migration-d03063d4                   kubernetes:batch/v1:Job        delete
~   vpc-native-user-profile-updated-sync-cron              kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-zombie-users-cron                     kubernetes:batch/v1:CronJob    update
~   vpc-native-generate-search-invites-cron                kubernetes:batch/v1:CronJob    update
~   vpc-native-post-analytics-clickhouse-cron              kubernetes:batch/v1:CronJob    update
~   vpc-native-update-current-streak-cron                  kubernetes:batch/v1:CronJob    update
~   vpc-native-expire-super-agent-trial-cron               kubernetes:batch/v1:CronJob    update
~   vpc-native-calculate-top-readers-cron                  kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-zombie-opportunities-cron             kubernetes:batch/v1:CronJob    update
-   vpc-native-api-clickhouse-migration-d03063d4           kubernetes:batch/v1:Job        delete
~   vpc-native-deployment                                  kubernetes:apps/v1:Deployment  update
~   vpc-native-materialize-yearly-best-post-archives-cron  kubernetes:batch/v1:CronJob    update
~   vpc-native-post-analytics-history-day-clickhouse-cron  kubernetes:batch/v1:CronJob    update
+   vpc-native-api-clickhouse-migration-edeb05dc           kubernetes:batch/v1:Job        create
~   vpc-native-daily-digest-cron                           kubernetes:batch/v1:CronJob    update
~   vpc-native-squad-posts-analytics-refresh-cron          kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-gifted-plus-cron                      kubernetes:batch/v1:CronJob    update
~   vpc-native-update-highlighted-views-cron               kubernetes:batch/v1:CronJob    update
~   vpc-native-personalized-digest-deployment              kubernetes:apps/v1:Deployment  update
~   vpc-native-update-tags-str-cron                        kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-expired-better-auth-sessions-cron     kubernetes:batch/v1:CronJob    update
~   vpc-native-channel-highlights-cron                     kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-channel-highlights-cron               kubernetes:batch/v1:CronJob    update
~   vpc-native-update-tag-materialized-views-cron          kubernetes:batch/v1:CronJob    update
~   vpc-native-user-posts-analytics-refresh-cron           kubernetes:batch/v1:CronJob    update
~   vpc-native-channel-digests-cron                        kubernetes:batch/v1:CronJob    update
~   vpc-native-generic-referral-reminder-cron              kubernetes:batch/v1:CronJob    update
~   vpc-native-check-analytics-report-cron                 kubernetes:batch/v1:CronJob    update
~   vpc-native-hourly-notification-cron                    kubernetes:batch/v1:CronJob    update
~   vpc-native-private-deployment                          kubernetes:apps/v1:Deployment  update
~   vpc-native-update-source-public-threshold-cron         kubernetes:batch/v1:CronJob    update
~   vpc-native-user-profile-analytics-clickhouse-cron      kubernetes:batch/v1:CronJob    update
~   vpc-native-ws-deployment                               kubernetes:apps/v1:Deployment  update
~   vpc-native-bg-deployment                               kubernetes:apps/v1:Deployment  update
~   vpc-native-rotate-weekly-quests-cron                   kubernetes:batch/v1:CronJob    update
~   vpc-native-update-views-cron                           kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-stale-user-transactions-cron          kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-zombie-user-companies-cron            kubernetes:batch/v1:CronJob    update
... and 11 other changes

@idoshamun idoshamun merged commit d848cc4 into main Apr 5, 2026
10 checks passed
@idoshamun idoshamun deleted the codex/highlight-unknown-share-fallback branch April 5, 2026 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant