Skip to content

refactor: remove no ai feed flag#3807

Merged
idoshamun merged 2 commits intomainfrom
eng-1272-remove-no_ai_feed-feature-flag-apply-control
Apr 18, 2026
Merged

refactor: remove no ai feed flag#3807
idoshamun merged 2 commits intomainfrom
eng-1272-remove-no_ai_feed-feature-flag-apply-control

Conversation

@idoshamun
Copy link
Copy Markdown
Member

Summary

  • remove the no_ai_feed treatment path from feed and feedV2 by dropping the API args, filtering config, and stored settings exposure
  • delete the legacy no-ai filter helper and update settings/boot responses plus tests to match the permanent control behavior
  • sanitize public settings flags so stale unknown keys do not leak back out from persisted JSON

Key decisions

  • remove the API contract for the deleted variant instead of leaving backward-compatible no-op fields behind
  • whitelist public settings flags to keep removed legacy keys from resurfacing in responses

Closes ENG-1272


Created by Huginn 🐦‍⬛

@pulumi
Copy link
Copy Markdown

pulumi Bot commented Apr 18, 2026

🍹 The Update (preview) for dailydotdev/api/prod (at f29c87e) was successful.

✨ Neo Explanation

Routine release deployment promoting commit `6530d0af` to prod across all services and cron jobs, with accompanying DB and ClickHouse schema migration jobs. ✅ Low Risk

This is a standard application deployment rolling out a new image version (3c0d51c...25a88478f29c87e...6530d0af) across all workloads. Every deployment and cron job is receiving the updated container image and version labels. The two migration Jobs (Postgres via TypeORM and ClickHouse) are being cycled in the normal pattern — old Jobs from the previous release are deleted and new ones are created for this release, which will run the schema migrations against both databases before or alongside the new application code.

🔵 Info — The DB and ClickHouse migration Jobs run with restartPolicy: Never, meaning a failed migration will not auto-retry. Confirm both new migration Jobs complete successfully before considering this deployment healthy, since a failed migration with new app pods running could cause runtime errors.

The GCP credentials warning on the provider is cosmetic and unrelated to the Kubernetes changes.

Resource Changes

    Name                                                       Type                           Operation
~   vpc-native-worker-job-deployment                           kubernetes:apps/v1:Deployment  update
~   vpc-native-generate-search-invites-cron                    kubernetes:batch/v1:CronJob    update
~   vpc-native-materialize-yearly-best-post-archives-cron      kubernetes:batch/v1:CronJob    update
~   vpc-native-squad-posts-analytics-refresh-cron              kubernetes:batch/v1:CronJob    update
~   vpc-native-check-analytics-report-cron                     kubernetes:batch/v1:CronJob    update
~   vpc-native-update-achievement-rarity-cron                  kubernetes:batch/v1:CronJob    update
~   vpc-native-sync-subscription-with-cio-cron                 kubernetes:batch/v1:CronJob    update
~   vpc-native-generic-referral-reminder-cron                  kubernetes:batch/v1:CronJob    update
+   vpc-native-api-clickhouse-migration-6530d0af               kubernetes:batch/v1:Job        create
~   vpc-native-personalized-digest-cron                        kubernetes:batch/v1:CronJob    update
~   vpc-native-update-current-streak-cron                      kubernetes:batch/v1:CronJob    update
~   vpc-native-user-posts-analytics-refresh-cron               kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-expired-better-auth-sessions-cron         kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-stale-user-transactions-cron              kubernetes:batch/v1:CronJob    update
~   vpc-native-user-profile-analytics-clickhouse-cron          kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-zombie-opportunities-cron                 kubernetes:batch/v1:CronJob    update
~   vpc-native-private-deployment                              kubernetes:apps/v1:Deployment  update
~   vpc-native-calculate-top-readers-cron                      kubernetes:batch/v1:CronJob    update
~   vpc-native-materialize-monthly-best-post-archives-cron     kubernetes:batch/v1:CronJob    update
~   vpc-native-bg-deployment                                   kubernetes:apps/v1:Deployment  update
~   vpc-native-clean-channel-highlights-cron                   kubernetes:batch/v1:CronJob    update
~   vpc-native-daily-digest-cron                               kubernetes:batch/v1:CronJob    update
-   vpc-native-api-clickhouse-migration-25a88478               kubernetes:batch/v1:Job        delete
~   vpc-native-post-analytics-clickhouse-cron                  kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-zombie-users-cron                         kubernetes:batch/v1:CronJob    update
~   vpc-native-rotate-daily-quests-cron                        kubernetes:batch/v1:CronJob    update
~   vpc-native-temporal-deployment                             kubernetes:apps/v1:Deployment  update
-   vpc-native-api-db-migration-25a88478                       kubernetes:batch/v1:Job        delete
~   vpc-native-personalized-digest-deployment                  kubernetes:apps/v1:Deployment  update
~   vpc-native-update-tag-materialized-views-cron              kubernetes:batch/v1:CronJob    update
~   vpc-native-validate-active-users-cron                      kubernetes:batch/v1:CronJob    update
~   vpc-native-ws-deployment                                   kubernetes:apps/v1:Deployment  update
~   vpc-native-hourly-notification-cron                        kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-zombie-user-companies-cron                kubernetes:batch/v1:CronJob    update
~   vpc-native-user-profile-analytics-history-clickhouse-cron  kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-gifted-plus-cron                          kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-zombie-images-cron                        kubernetes:batch/v1:CronJob    update
~   vpc-native-update-tags-str-cron                            kubernetes:batch/v1:CronJob    update
~   vpc-native-expire-super-agent-trial-cron                   kubernetes:batch/v1:CronJob    update
~   vpc-native-rotate-weekly-quests-cron                       kubernetes:batch/v1:CronJob    update
~   vpc-native-deployment                                      kubernetes:apps/v1:Deployment  update
... and 11 other changes

@idoshamun idoshamun merged commit 26565db into main Apr 18, 2026
8 of 10 checks passed
@idoshamun idoshamun deleted the eng-1272-remove-no_ai_feed-feature-flag-apply-control branch April 18, 2026 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant