Merge pull request #288 from daita-technologies/fix/feedback_form

ttattl · web-flow · commit 1f34b023e78d · 2022-11-19T23:46:43.000+07:00
fix: error parse get presign url response
diff --git a/src/components/FeedbackComponent/FeedbackForm.tsx b/src/components/FeedbackComponent/FeedbackForm.tsx
@@ -329,6 +329,8 @@ export const FeedbackFormSlack = function ({
             if (onSendFail) onSendFail();
             resolve({ action: FeedbackFormAction.NO_ACTION });
           });
+      } else {
+        resolve({ action: FeedbackFormAction.NO_ACTION });
       }
     });
 
diff --git a/src/services/authApi.tsx b/src/services/authApi.tsx
@@ -54,7 +54,7 @@ const service = new Service(axios);
 
 service.register({
   onResponse(response: any) {
-    if (response && typeof response.data === "string") {
+    if (response && typeof response.data === "string" && response.data !== "") {
       const apiData = JSON.parse(response.data);
 
       if (

Original file line number	Diff line number	Diff line change
`@@ -329,6 +329,8 @@ export const FeedbackFormSlack = function ({`
`329`	`329`	`if (onSendFail) onSendFail();`
`330`	`330`	`resolve({ action: FeedbackFormAction.NO_ACTION });`
`331`	`331`	`});`
	`332`	`+ } else {`
	`333`	`+ resolve({ action: FeedbackFormAction.NO_ACTION });`
`332`	`334`	`}`
`333`	`335`	`});`
`334`	`336`