fix(compaction): fix TestHash function in BloomFilter (alibaba#221)

lszskye · web-flow · commit 2d8da13fa3e9 · 2026-04-13T14:49:33.000+08:00
diff --git a/src/paimon/common/utils/bloom_filter.cpp b/src/paimon/common/utils/bloom_filter.cpp
@@ -56,7 +56,7 @@ BloomFilter::BloomFilter(int64_t expected_entries, int32_t byte_length)
 }
 
 Status BloomFilter::AddHash(int32_t hash1) {
-    int32_t hash2 = hash1 >> 16;
+    auto hash2 = static_cast<int32_t>(static_cast<uint32_t>(hash1) >> 16);
 
     for (int32_t i = 1; i <= num_hash_functions_; i++) {
         int32_t combined_hash = hash1 + (i * hash2);
@@ -71,7 +71,7 @@ Status BloomFilter::AddHash(int32_t hash1) {
 }
 
 bool BloomFilter::TestHash(int32_t hash1) const {
-    int32_t hash2 = hash1 >> 16;
+    auto hash2 = static_cast<int32_t>(static_cast<uint32_t>(hash1) >> 16);
 
     for (int32_t i = 1; i <= num_hash_functions_; i++) {
         int32_t combined_hash = hash1 + (i * hash2);

Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,7 @@ BloomFilter::BloomFilter(int64_t expected_entries, int32_t byte_length)`
`56`	`56`	`}`
`57`	`57`
`58`	`58`	`Status BloomFilter::AddHash(int32_t hash1) {`
`59`		`- int32_t hash2 = hash1 >> 16;`
	`59`	`+ auto hash2 = static_cast<int32_t>(static_cast<uint32_t>(hash1) >> 16);`
`60`	`60`
`61`	`61`	`for (int32_t i = 1; i <= num_hash_functions_; i++) {`
`62`	`62`	`int32_t combined_hash = hash1 + (i * hash2);`
`@@ -71,7 +71,7 @@ Status BloomFilter::AddHash(int32_t hash1) {`
`71`	`71`	`}`
`72`	`72`
`73`	`73`	`bool BloomFilter::TestHash(int32_t hash1) const {`
`74`		`- int32_t hash2 = hash1 >> 16;`
	`74`	`+ auto hash2 = static_cast<int32_t>(static_cast<uint32_t>(hash1) >> 16);`
`75`	`75`
`76`	`76`	`for (int32_t i = 1; i <= num_hash_functions_; i++) {`
`77`	`77`	`int32_t combined_hash = hash1 + (i * hash2);`