Skip to content

Commit 393b613

Browse files
lxy-9602lxy-9602
authored
test: add unittest (alibaba#231)
1 parent d825d7b commit 393b613

144 files changed

Lines changed: 1240 additions & 224 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

include/paimon/utils/bucket_function_type.h renamed to include/paimon/bucket/bucket_function_type.h

File renamed without changes.

include/paimon/utils/bucket_id_calculator.h renamed to include/paimon/bucket/bucket_id_calculator.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,10 @@
1919
#include <memory>
2020
#include <vector>
2121

22+
#include "paimon/bucket/bucket_function_type.h"
2223
#include "paimon/memory/memory_pool.h"
2324
#include "paimon/result.h"
2425
#include "paimon/status.h"
25-
#include "paimon/utils/bucket_function_type.h"
2626
#include "paimon/visibility.h"
2727

2828
struct ArrowSchema;

‎src/paimon/CMakeLists.txt‎

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -132,10 +132,10 @@ set(PAIMON_COMMON_SRCS
132132
common/utils/bit_set.cpp
133133
common/utils/bloom_filter.cpp
134134
common/utils/bloom_filter64.cpp
135-
common/utils/bucket_id_calculator.cpp
136135
common/utils/crc32c.cpp
137136
common/utils/decimal_utils.cpp
138137
common/utils/delta_varint_compressor.cpp
138+
common/utils/fields_comparator.cpp
139139
common/utils/path_util.cpp
140140
common/utils/range.cpp
141141
common/utils/read_ahead_cache.cpp
@@ -151,6 +151,7 @@ set(PAIMON_CORE_SRCS
151151
core/append/bucketed_append_compact_manager.cpp
152152
core/bucket/hive_bucket_function.cpp
153153
core/bucket/mod_bucket_function.cpp
154+
core/bucket/bucket_id_calculator.cpp
154155
core/casting/binary_to_string_cast_executor.cpp
155156
core/casting/boolean_to_decimal_cast_executor.cpp
156157
core/casting/boolean_to_numeric_cast_executor.cpp
@@ -304,7 +305,6 @@ set(PAIMON_CORE_SRCS
304305
core/table/source/data_evolution_batch_scan.cpp
305306
core/tag/tag.cpp
306307
core/utils/field_mapping.cpp
307-
core/utils/fields_comparator.cpp
308308
core/utils/file_store_path_factory.cpp
309309
core/utils/file_utils.cpp
310310
core/utils/manifest_meta_reader.cpp
@@ -350,6 +350,7 @@ if(PAIMON_BUILD_TESTS)
350350
common/memory/bytes_test.cpp
351351
common/memory/memory_segment_test.cpp
352352
common/memory/memory_segment_utils_test.cpp
353+
common/memory/memory_slice_test.cpp
353354
STATIC_LINK_LIBS
354355
paimon_shared
355356
test_utils_static
@@ -417,6 +418,7 @@ if(PAIMON_BUILD_TESTS)
417418
common/io/data_input_output_stream_test.cpp
418419
common/io/buffered_input_stream_test.cpp
419420
common/io/memory_segment_output_stream_test.cpp
421+
common/io/cache_input_stream_test.cpp
420422
common/io/offset_input_stream_test.cpp
421423
common/lookup/sort/sort_lookup_store_test.cpp
422424
common/logging/logging_test.cpp
@@ -455,13 +457,13 @@ if(PAIMON_BUILD_TESTS)
455457
common/utils/bloom_filter_test.cpp
456458
common/utils/bloom_filter64_test.cpp
457459
common/utils/xxhash_test.cpp
458-
common/utils/bucket_id_calculator_test.cpp
459460
common/utils/binary_row_partition_computer_test.cpp
460461
common/utils/bin_packing_test.cpp
461462
common/utils/data_converter_utils_test.cpp
462463
common/utils/date_time_utils_test.cpp
463464
common/utils/delta_varint_compressor_test.cpp
464465
common/utils/field_type_utils_test.cpp
466+
common/utils/fields_comparator_test.cpp
465467
common/utils/internal_row_utils_test.cpp
466468
common/utils/jsonizable_test.cpp
467469
common/utils/linked_hash_map_test.cpp
@@ -524,6 +526,7 @@ if(PAIMON_BUILD_TESTS)
524526
core/append/bucketed_append_compact_manager_test.cpp
525527
core/bucket/default_bucket_function_test.cpp
526528
core/bucket/hive_bucket_function_test.cpp
529+
core/bucket/bucket_id_calculator_test.cpp
527530
core/bucket/mod_bucket_function_test.cpp
528531
core/casting/cast_executor_factory_test.cpp
529532
core/casting/cast_executor_test.cpp
@@ -666,7 +669,6 @@ if(PAIMON_BUILD_TESTS)
666669
core/utils/branch_manager_test.cpp
667670
core/utils/file_store_path_factory_cache_test.cpp
668671
core/utils/field_mapping_test.cpp
669-
core/utils/fields_comparator_test.cpp
670672
core/utils/file_store_path_factory_test.cpp
671673
core/utils/file_utils_test.cpp
672674
core/utils/manifest_meta_reader_test.cpp

‎src/paimon/common/compression/block_decompressor.cpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ int32_t BlockDecompressor::ReadIntLE(const char* buf) {
2727
Status BlockDecompressor::ValidateLength(int32_t compressed_len, int32_t original_len) {
2828
if (original_len < 0 || compressed_len < 0 || (original_len == 0 && compressed_len != 0) ||
2929
(original_len != 0 && compressed_len == 0)) {
30-
return Status::IOError(
30+
return Status::Invalid(
3131
fmt::format("Input is corrupted, compressed_len={}, , original_len={}", compressed_len,
3232
original_len));
3333
}

‎src/paimon/common/compression/lz4/lz4_block_compressor.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ class Lz4BlockCompressor : public BlockCompressor {
3636
LZ4_compress_default(src, dst + BlockCompressor::HEADER_LENGTH, src_length,
3737
dst_length - BlockCompressor::HEADER_LENGTH);
3838
if (compressed_size < 0) {
39-
return Status::IOError(fmt::format("Compression failed with code {}", compressed_size));
39+
return Status::Invalid(fmt::format("Compression failed with code {}", compressed_size));
4040
}
4141
WriteIntLE(compressed_size, dst);
4242
WriteIntLE(src_length, dst + 4);

‎src/paimon/common/compression/lz4/lz4_block_decompressor.h‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,19 +33,19 @@ class Lz4BlockDecompressor : public BlockDecompressor {
3333
PAIMON_RETURN_NOT_OK(ValidateLength(compressed_len, original_len));
3434

3535
if (dst_length < original_len) {
36-
return Status::IOError(
36+
return Status::Invalid(
3737
fmt::format("Buffer length too small, compressed_len= {}, original_len={}",
3838
compressed_len, original_len));
3939
}
4040

4141
if (src_length - HEADER_LENGTH < compressed_len) {
42-
return Status::IOError("Source data is not integral for decompression.");
42+
return Status::Invalid("Source data is not integral for decompression.");
4343
}
4444

4545
int32_t decompressed_size =
4646
LZ4_decompress_safe(src + HEADER_LENGTH, dst, src_length - HEADER_LENGTH, dst_length);
4747
if (decompressed_size != original_len) {
48-
return Status::IOError(fmt::format("Input is corrupted, expected {}, but got {}",
48+
return Status::Invalid(fmt::format("Input is corrupted, expected {}, but got {}",
4949
original_len, decompressed_size));
5050
}
5151
return decompressed_size;

‎src/paimon/common/compression/zstd/zstd_block_compressor.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ class ZstdBlockCompressor : public BlockCompressor {
3636
int32_t dst_length) override {
3737
size_t const compressed_size = ZSTD_compress(dst, dst_length, src, src_length, level_);
3838
if (ZSTD_isError(compressed_size)) {
39-
return Status::IOError(fmt::format("Compression failed with code {}", compressed_size));
39+
return Status::Invalid(fmt::format("Compression failed with code {}", compressed_size));
4040
}
4141
return compressed_size;
4242
}

‎src/paimon/common/compression/zstd/zstd_block_decompressor.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ class ZstdBlockDecompressor : public BlockDecompressor {
3030
int32_t dst_length) override {
3131
int32_t decompressed_size = ZSTD_decompress(dst, dst_length, src, src_length);
3232
if (ZSTD_isError(decompressed_size)) {
33-
return Status::IOError(
33+
return Status::Invalid(
3434
fmt::format("Input is corrupted with return code {}", decompressed_size));
3535
}
3636
return decompressed_size;

‎src/paimon/common/data/binary_row_test.cpp‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -413,7 +413,7 @@ TEST_F(BinaryRowTest, TestZeroOutPaddingString) {
413413
writer.Reset();
414414
writer.WriteString(0, BinaryString::FromString("wahahah", pool.get()));
415415
writer.Complete();
416-
int hash1 = row.HashCode();
416+
int32_t hash1 = row.HashCode();
417417

418418
writer.Reset();
419419
for (int32_t i = 0; i < bytes_size; i++) {
@@ -423,7 +423,7 @@ TEST_F(BinaryRowTest, TestZeroOutPaddingString) {
423423
writer.Reset();
424424
writer.WriteString(0, BinaryString::FromString("wahahah", pool.get()));
425425
writer.Complete();
426-
int hash2 = row.HashCode();
426+
int32_t hash2 = row.HashCode();
427427

428428
ASSERT_EQ(hash2, hash1);
429429
}

‎src/paimon/common/data/binary_section_test.cpp‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ class BinarySectionTest : public ::testing::Test {
2727
pool_ = GetDefaultPool();
2828

2929
segment_ = MemorySegment::AllocateHeapMemory(2048, pool_.get());
30-
for (int i = 0; i < 2048; ++i) {
30+
for (int32_t i = 0; i < 2048; ++i) {
3131
segment_.Put(i, static_cast<uint8_t>(i % 128));
3232
}
3333
offset_ = 0;
@@ -53,7 +53,7 @@ TEST_F(BinarySectionTest, EqualityOperator) {
5353
TEST_F(BinarySectionTest, ToBytes) {
5454
auto bytes = binary_section_.ToBytes(pool_.get());
5555
ASSERT_EQ(bytes->size(), size_in_bytes_);
56-
for (int i = 0; i < size_in_bytes_; ++i) {
56+
for (int32_t i = 0; i < size_in_bytes_; ++i) {
5757
EXPECT_EQ(static_cast<uint8_t>(bytes->data()[i]), static_cast<uint8_t>(i % 128));
5858
}
5959
}
@@ -68,7 +68,7 @@ TEST_F(BinarySectionTest, ReadBinary) {
6868
auto bytes =
6969
BinarySection::ReadBinary(segment_, 0, offset_, variable_part_offset_and_len, pool_.get());
7070
ASSERT_EQ(bytes->size(), size_in_bytes_);
71-
for (int i = 0; i < size_in_bytes_; ++i) {
71+
for (int32_t i = 0; i < size_in_bytes_; ++i) {
7272
EXPECT_EQ(static_cast<uint8_t>(bytes->data()[i]), static_cast<uint8_t>(i % 128));
7373
}
7474
}

0 commit comments

Comments
 (0)