Chore/update upstream#89
Closed
oriori1703 wants to merge 46 commits into
Closed
Conversation
configs -> config in init.lua
Neovim 0.11 is now stable
* move telescope related lsp functions inside the telscope plugin declaration block * explicitly enable telescope plugin, add some comments explainging why * update comments with suggestions from @oriori1703 Co-authored-by: Ori Perry <48057913+oriori1703@users.noreply.github.com> * fix formatting in accordance to stylua so that pipeline passes --------- Co-authored-by: Philipp Szechenyi <philipp.szechenyi@cgm.com> Co-authored-by: Philipp Szechenyi <45265588+szechp@users.noreply.github.com> Co-authored-by: Ori Perry <48057913+oriori1703@users.noreply.github.com> Co-authored-by: philipp <philipp@philipps-MacBook-Pro.local>
The current comment in .gitignore for lazy-lock.json suggests to uncomment it yourself, but you actually need to comment it instead. This change modifies the comment to clarify the recommended approach for kickstart users.
This could help beginners to get autocompletion, catch mistakes earlier, and allow them to skip the docs for simple configs. This is not perfect because a lot of the plugins type all of their keys as required, even though they have defaults, but this is good enough.
Add type hints to plugin options where possible
Adds 'gr' to which-keys documentation, so users can see that LSP actions are grouped after 'gr' key binds. Co-authored-by: thiago-negri <evohunz@gmail.com>
…mment Clarify comment in .gitignore for lazy-lock.json
Clarify gitsigns keymap for which-key
…ency Remove blink from nvim-lspconfig dependencies
oriori1703
force-pushed
the
chore/update-upstream
branch
from
d3995bf to
6f7801d
Compare
Owner
Ah, awesome, it finally happened? Congrats! :D |
Owner
|
Hmm, github says: This branch cannot be rebased due to conflicts I think I'll need to sync manually as usual... |
Owner
|
I merged the upstream changes, there's a few styling differences compared to this PR but I think functionally should be the same. |
Author
|
Sorry for the rebase issue. I will try to better match the existing code next time 😊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to the latest changes in upstream kickstart
BTW, I have recently became a maintainer on the main kickstart.nvim :)
I'm still not sure if kickstart needs to go in the modular direction, but I really like your project so I thought I will help a bit