Merge pull request #1 from damassi/feat/ci

feat: add ci runner

Author: damassi

.github/workflows/type-check.yml

@@ -0,0 +1,20 @@
+name: Type Check
+
+on: [push, pull_request]
+
+jobs:
+  type-check:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Set up Python
+        uses: actions/setup-python@v5
+        with:
+          python-version: "3.12"
+
+      - name: Install uv
+        uses: astral-sh/setup-uv@v4
+
+      - name: Run mypy
+        run: uv run mypy src/agent_chat_cli

CLAUDE.md

@@ -1,7 +1,8 @@
-# CLAUDE.md System Settings
+# CLAUDE.md System Prompt
 
 ## Rules
 
 - The project uses `uv`, `ruff` and `mypy`
 - Run commands should be prefixed with `uv`: `uv run ...`
 - Use `asyncio` features, if such is needed
+- Absolutely no useless comments! Every class and method does not need to be documented (unless it is legitimetly complex or "lib-ish")

README.md

@@ -19,3 +19,11 @@ This app uses [uv](https://github.com/astral-sh/uv) for package management so fi
 - `uv run chat`
 
 Additional MCP servers are configured in `agent-chat-cli.config.yaml` and prompts added within the `prompts` folder.
+
+## Development
+
+- Install pre-commit hooks
+  - `uv run pre-commit install`
+- Typechecking is via [MyPy](https://github.com/python/mypy):
+  - `uv run mypy src`
+- Linting and formatting is via [Ruff](https://docs.astral.sh/ruff/)

src/agent_chat_cli/utils/config.py

@@ -57,34 +57,37 @@ def load_config(
         raw_config = yaml.safe_load(f)
 
     base_system_prompt = ""
-    if "system_prompt" in raw_config:
+
+    if raw_config.get("system_prompt"):
         base_system_prompt = load_prompt(raw_config["system_prompt"])
 
-    if "agents" in raw_config:
+    if raw_config.get("agents"):
         for agent_config in raw_config["agents"].values():
-            if "prompt" in agent_config:
+            if agent_config.get("prompt"):
                 agent_config["prompt"] = load_prompt(agent_config["prompt"])
 
     mcp_server_prompts = []
-    if "mcp_servers" in raw_config:
+
+    if raw_config.get("mcp_servers"):
         enabled_servers = {
             name: config
             for name, config in raw_config["mcp_servers"].items()
             if config.get("enabled", True)
         }
+
         raw_config["mcp_servers"] = enabled_servers
 
         for server_config in enabled_servers.values():
-            if "prompt" in server_config and server_config["prompt"]:
+            if server_config.get("prompt"):
                 loaded_prompt = load_prompt(server_config["prompt"])
                 server_config["prompt"] = loaded_prompt
                 mcp_server_prompts.append(loaded_prompt)
 
-            if "env" in server_config:
+            if server_config.get("env"):
                 for key, value in server_config["env"].items():
                     server_config["env"][key] = os.path.expandvars(value)
 
-            if "args" in server_config:
+            if server_config.get("args"):
                 server_config["args"] = [
                     os.path.expandvars(arg) for arg in server_config["args"]
                 ]