dont add code challenge if disablePkce is true#2159
Merged
FabianGosebrink merged 1 commit intoDec 8, 2025
Conversation
salahBouragba
force-pushed
the
remove-code-challenge-params
branch
from
d490145 to
273e047
Compare
Collaborator
|
Thanks for this PR. Which issue is going to be fixed with this. Can you link it? Thanks! |
Contributor
Author
|
It's this Issue |
Collaborator
|
Thanks! Updated the initial post. |
FabianGosebrink
approved these changes
Dec 8, 2025
4 tasks
timdeschryver
pushed a commit
to timdeschryver/angular-auth-oidc-client
that referenced
this pull request
Jun 15, 2026
createBodyForParCodeFlowRequest was unconditionally appending code_challenge and code_challenge_method to the PAR request body, even when disablePkce: true. Strict authorization servers reject the request because code_challenge is invalid (or, after damienbod#2159, empty in the standard authorize URL but populated here). Mirror the pattern used in createAuthorizeUrl: route challenge generation through the existing getCodeChallenge helper (which short-circuits when PKCE is disabled) and guard the param append. Adds a unit test asserting that code_challenge, code_challenge_method, the code verifier creation, and the challenge generation are all skipped when disablePkce is true. Refs damienbod#2077
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2157