Fix: don't send code_challenge in PAR flow when disablePkce is true#2209
Merged
Conversation
createBodyForParCodeFlowRequest was unconditionally appending code_challenge and code_challenge_method to the PAR request body, even when disablePkce: true. Strict authorization servers reject the request because code_challenge is invalid (or, after #2159, empty in the standard authorize URL but populated here). Mirror the pattern used in createAuthorizeUrl: route challenge generation through the existing getCodeChallenge helper (which short-circuits when PKCE is disabled) and guard the param append. Adds a unit test asserting that code_challenge, code_challenge_method, the code verifier creation, and the challenge generation are all skipped when disablePkce is true. Refs #2077
CI's `npm ci` was failing with "Missing from lock file" for @emnapi/core@1.10.0, @emnapi/runtime@1.10.0, @types/node@25.9.1, and chokidar@4.0.3. Regenerated the lockfile under Node 20 (matching CI's setup-node@v5 with node-version: 20) so the required transitive entries are present. Verified locally with `npm ci --dry-run` under Node 20.
Collaborator
Author
|
@damienbod Please Review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
disablePkcebug from [Question]: Authentication without PKCE - invalid query parameters #2077 in the PAR (Pushed Authorization Request) flow path that dont add code challenge if disablePkce is true #2159 didn't cover.createBodyForParCodeFlowRequestnow skips both PKCE param generation and thecode_challenge/code_challenge_methodappend whendisablePkce: true.createAuthorizeUrlby routing challenge generation through the existing privategetCodeChallengehelper (which short-circuits when PKCE is disabled).Background
Issue #2077 reported that strict authorization servers reject
code_challenge=(empty) whendisablePkce: true. PR #2159 fixed this for the standard authorize URL by adding a!configuration.disablePkceguard increateAuthorizeUrl. The PAR flow constructs its request body in a separate method (createBodyForParCodeFlowRequest) that was missed — it unconditionally generated a code verifier and appended a populatedcode_challenge, defeating the purpose ofdisablePkcefor PAR consumers.Changes
url.service.ts:createBodyForParCodeFlowRequestnow calls the existinggetCodeChallenge(configuration)helper instead of inlining the verifier+challenge generation, and guards the twoparams.append('code_challenge'...)/params.append('code_challenge_method'...)calls behind!configuration.disablePkce.url.service.spec.ts: new testomits code_challenge and code_challenge_method when disablePkce is trueasserting the output URL is clean and thatcreateCodeVerifier/generateCodeChallengeare not called.Test plan
Refs #2077
Related: #2159
🤖 Generated with Claude Code