chore: sync package-lock.json with package.json#2214
Merged
Conversation
CI's `npm ci` step has been failing on every PR opened against main with "Missing from lock file" entries for @emnapi/core@1.10.0, @emnapi/runtime@1.10.0, @types/node@25.9.1, and chokidar@4.0.3. These transitive deps are required by @angular/build under Node 20 (the version CI uses via setup-node@v5) but were not present in the lockfile that landed on main after the Angular 21 upgrade. Regenerated locally under Node 20 / npm 10.8.2 to match CI; verified with `npm ci --dry-run`. No package.json changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Regenerate
package-lock.jsonso it matches the currentpackage.json(Angular 21).+53 / -12 lines, single file. No
package.jsonchanges.Why
CI uses Node 20 (via
setup-node@v5), and on every PR thenpm cistep fails with:These transitive deps are pulled in by
@angular/buildunder Node 20 but were never added to the lockfile after the Angular 21 upgrade.npm installadds them;npm ci(which is strict) rejects the existing lockfile because they're not there.This blocks every open PR against
main. Splitting the fix into its own chore PR so it can be merged independently of any feature work.Test plan
npm ci --dry-runsucceeds against the new lockfile (added 100 packages in 413ms)Installing Dependenciesstep (Fix: don't send code_challenge in PAR flow when disablePkce is true #2209, fix: verify nonce against original after refresh instead of overwriting it #2211, fix!: return Observable from logoffLocal and logoffLocalMultiple #2212 affected)Follow-up
PR #2209 currently also includes a (now-redundant) version of this lockfile sync. Once this chore PR lands, that part of #2209 can be dropped via rebase or just superseded when the maintainer merges
maininto #2209.🤖 Generated with Claude Code