modifications to the librispeech-parakeet#1
Open
bhargav191098 wants to merge 2 commits into
Open
Conversation
danbev
reviewed
May 8, 2026
| fprintf(stderr, "Loading Parakeet model from: %s\n", params.model.c_str()); | ||
| } | ||
|
|
||
| struct parakeet_context * pctx = parakeet_init_from_file_with_params(params.model.c_str(), ctx_params); |
Owner
There was a problem hiding this comment.
I've added this to the main branch as discovered a bug in the process releated to the lstm state not being cleared. I'll add you as co-author to the PR 👍
| @@ -0,0 +1,270 @@ | |||
| #!/usr/bin/env python3 | |||
Owner
There was a problem hiding this comment.
I'd prefer to leave this out of this commit and we can do this in a follow up commit. The original PR is very large and it will take reviewers some time to go through. Keeping this the same as whispers test code will make this a little easier I think. I was able to run the make version on windows so it will work there with some dependency installations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
+The eval.mk was expecting cuda-89 build, directory but since the build-dir name is user specified, it made sense to make the cli exe build directory as a required parameter to the benchmark py script.