diff --git a/repo_subpaths_for_grammar_check.md b/repo_subpaths_for_grammar_check.md index c227f4430ef..57da7710d9b 100644 --- a/repo_subpaths_for_grammar_check.md +++ b/repo_subpaths_for_grammar_check.md @@ -17,6 +17,6 @@ Status legend: `[ ]` pending, `[~]` in progress, `[x]` complete - [x] `tests/shanghai/**/*.py` (~19 files) - [x] `tests/byzantium/**/*.py` (~11 files) - [x] `tests/istanbul/**/*.py`, `berlin/**/*.py` (~18 files) -- [ ] `tests/constantinople/**/*.py`, `amsterdam/**/*.py` (~16 files) +- [x] `tests/constantinople/**/*.py`, `amsterdam/**/*.py` (~16 files) - [ ] `tests/london/**/*.py`, `homestead/**/*.py`, `paris/**/*.py` (~17 files) - [ ] `tests/*.py`, `tests/common/**/*.py`, `tests/evm_tools/**/*.py` (~5 files) diff --git a/tests/amsterdam/eip7928_block_level_access_lists/test_block_access_lists.py b/tests/amsterdam/eip7928_block_level_access_lists/test_block_access_lists.py index 4f51fd946b3..d6c7948f13b 100644 --- a/tests/amsterdam/eip7928_block_level_access_lists/test_block_access_lists.py +++ b/tests/amsterdam/eip7928_block_level_access_lists/test_block_access_lists.py @@ -336,7 +336,7 @@ def test_bal_self_destruct( } # If the account was self-destructed in the same transaction, - # we expect the account to non-existent and its balance to be 0. + # we expect the account to be non-existent and its balance to be 0. if self_destruct_in_same_tx: post.update( { diff --git a/tests/amsterdam/eip7928_block_level_access_lists/test_block_access_lists_eip7702.py b/tests/amsterdam/eip7928_block_level_access_lists/test_block_access_lists_eip7702.py index 5ff9e7b135b..1e14bb5a1b3 100644 --- a/tests/amsterdam/eip7928_block_level_access_lists/test_block_access_lists_eip7702.py +++ b/tests/amsterdam/eip7928_block_level_access_lists/test_block_access_lists_eip7702.py @@ -143,7 +143,7 @@ def test_bal_7702_delegation_update( oracle1 = pre.deploy_contract(code=Op.STOP) oracle2 = pre.deploy_contract(code=Op.STOP) - ## Perhaps create pre existing delegation, + ## Perhaps create a pre-existing delegation, ## see `test_bal_7702_delegated_storage_access` since ## `test_bal_7702_delegation_create` already tests creation tx_create = Transaction( @@ -268,7 +268,7 @@ def test_bal_7702_delegation_clear( oracle = pre.deploy_contract(code=Op.STOP) abyss = Spec7702.RESET_DELEGATION_ADDRESS - ## Perhaps create pre existing delegation, + ## Perhaps create a pre-existing delegation, ## see `test_bal_7702_delegated_storage_access` since ## `test_bal_7702_delegation_create` already tests creation tx_create = Transaction( diff --git a/tests/constantinople/eip1014_create2/test_create_returndata.py b/tests/constantinople/eip1014_create2/test_create_returndata.py index 26b754da9c6..918af9cfc74 100644 --- a/tests/constantinople/eip1014_create2/test_create_returndata.py +++ b/tests/constantinople/eip1014_create2/test_create_returndata.py @@ -1,7 +1,9 @@ """ -Return data management around create2 Port -call_outsize_then_create2_successful_then_returndatasizeFiller.json test Port -call_then_create2_successful_then_returndatasizeFiller.json test. +Test CREATE2 return data memory management. + +Ported tests for return data management around CREATE2: +- call_outsize_then_create2_successful_then_returndatasizeFiller.json +- call_then_create2_successful_then_returndatasizeFiller.json """ import pytest diff --git a/tests/constantinople/eip145_bitwise_shift/spec.py b/tests/constantinople/eip145_bitwise_shift/spec.py index e4822197a4c..b6931c814c7 100644 --- a/tests/constantinople/eip145_bitwise_shift/spec.py +++ b/tests/constantinople/eip145_bitwise_shift/spec.py @@ -23,8 +23,8 @@ class Spec: https://eips.ethereum.org/EIPS/eip-145. """ - # Below are GPT o4-mini-high implementation of shift functions It can - # contain bugs, treat it with caution and refer to EVM implementations + # Below is a GPT o4-mini-high implementation of shift functions. It can + # contain bugs, treat it with caution and refer to EVM implementations. @staticmethod def sar(shift: int, value: int) -> int: """