Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/running_tests/test_formats/blockchain_test.md
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ List of decoded transactions included in the block RLP.

#### - `uncleHeaders`: [`List`](./common_types.md#list)`[`[`FixtureHeader`](#fixturetransaction)`]`

List of uncle headers included in the block RLP. An empty list post merge.
List of uncle headers included in the block RLP. An empty list post-merge.

#### - `withdrawals`: [`Optional`](./common_types.md#optional)`[`[`List`](./common_types.md#list)`[`[`FixtureWithdrawal`](#fixturewithdrawal)`]]` `(fork: Shanghai)`

Expand Down Expand Up @@ -280,7 +280,7 @@ Max fee per blob gas to pay (Transaction type 3)

#### - `blobVersionedHashes`: [`List`](./common_types.md#list)`[`[`Hash`](./common_types.md#hash)`]` `(fork: Cancun)`

Max fee per blob gas to pay (Transaction type 3)
List of blob versioned hashes the transaction includes (Transaction type 3).

#### - `v`: [`ZeroPaddedHexNumber`](./common_types.md#zeropaddedhexnumber)

Expand Down
2 changes: 1 addition & 1 deletion docs/running_tests/test_formats/blockchain_test_engine.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ These are produced by the `StateTest` and `BlockchainTest` test specs.

## Description

The Blockchain Engine Test fixture format is used to test block validation and the consensus rules of the Ethereum blockchain, when a block is delivered through the Engine API as a `engine_newPayloadVX` directive.
The Blockchain Engine Test fixture format is used to test block validation and the consensus rules of the Ethereum blockchain, when a block is delivered through the Engine API as an `engine_newPayloadVX` directive.

It does so by defining a pre-execution state, a series of blocks as `engine_newPayloadVX` directives, and a post-execution state, verifying that, after all the blocks have been processed, appended if valid or rejected if invalid, the result is the expected post-execution state.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ For each [`BlockchainTestEngineXFixture`](#blockchaintestenginexfixture) test ob
- If [`postStateDiff`](#-poststatediff-optionalalloc) is present:
- Apply the state differences to the pre-allocation group
- Verify the resulting state matches the client's final state
- If `post` field were present (not typical), verify it directly
- If the `post` field were present (not typical), verify it directly

## Structures

Expand Down
2 changes: 1 addition & 1 deletion docs/running_tests/test_formats/transaction_test.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ These are produced by the `TransactionTest` test spec.

## Description

The transaction test fixture format is used to test client's transaction RLP parsing without executing the transaction on the EVM.
The transaction test fixture format is used to test a client's transaction RLP parsing without executing the transaction on the EVM.

It does so by defining a transaction binary RLP representation, and whether the transaction should be accepted or rejected by the client in each fork.

Expand Down
4 changes: 4 additions & 0 deletions grammar_manual_verification.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,7 @@ Format (but don't add a codeblock for each item):
---

<!-- Issues will be appended below by Claude Code -->

- [ ] docs/running_tests/test_formats/state_test.md:61 - "Mapping of lists of post for verification per fork"
Suggestion: "Mapping of lists of `FixtureForkPost` for verification per fork" or "Mapping of lists for the `post` field for verification per fork"
Reason: The word "post" without backticks is ambiguous - unclear if referring to the field name or a technical term
2 changes: 1 addition & 1 deletion repo_subpaths_for_grammar_check.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ Status legend: `[ ]` pending, `[~]` in progress, `[x]` complete
## docs/running_tests (~3274 lines total, split into 4 batches)

- [x] `docs/running_tests/test_formats/common_types.md`, `blockchain_test.md`, `blockchain_test_sync.md` (~920 lines, 3 files)
- [ ] `docs/running_tests/test_formats/blockchain_test_engine.md`, `blockchain_test_engine_x.md`, `state_test.md`, `transaction_test.md`, `exceptions.md`, `index.md` (~650 lines, 6 files)
- [x] `docs/running_tests/test_formats/blockchain_test_engine.md`, `blockchain_test_engine_x.md`, `state_test.md`, `transaction_test.md`, `exceptions.md`, `index.md` (~650 lines, 6 files)
- [ ] `docs/running_tests/consume/**/*.md`, `docs/running_tests/execute/**/*.md` (~950 lines, 10 files)
- [ ] `docs/running_tests/hive/**/*.md`, `docs/running_tests/*.md` (~750 lines, 10 files)

Expand Down
Loading