Skip to content
This repository was archived by the owner on Sep 16, 2020. It is now read-only.

Adds and exports ButtonType enum for type prop#315

Open
maxschmeling wants to merge 2 commits intodancormier:masterfrom
maxschmeling:patch-1
Open

Adds and exports ButtonType enum for type prop#315
maxschmeling wants to merge 2 commits intodancormier:masterfrom
maxschmeling:patch-1

Conversation

@maxschmeling
Copy link
Copy Markdown

This is just a slight improvement to the TypeScript support.

@maxschmeling
Copy link
Copy Markdown
Author

The keyof typeof ButtonType part is necessary to make this backward compatible and not force every TypeScript based consumer of this component to switch to the enum type.

Feel free to just close this if you think it's not worth the change. But I like the enum, personally.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant