Skip to content
This repository was archived by the owner on Feb 15, 2025. It is now read-only.

fix regex for parsing gitlab access informations#1351

Open
gabrhel wants to merge 1 commit into
dancryer:masterfrom
gabrhel:fix/gitlab-access-info
Open

fix regex for parsing gitlab access informations#1351
gabrhel wants to merge 1 commit into
dancryer:masterfrom
gabrhel:fix/gitlab-access-info

Conversation

@gabrhel
Copy link
Copy Markdown

@gabrhel gabrhel commented Feb 27, 2019

Contribution Type: bug fix
Link to Intent to Implement: none
Link to Bug: #1143

This pull request affects the following areas:

  • Front-End
  • Builder
  • Build Plugins

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributing guidelines?
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I have created or updated the relevant documentation for this change on the PHPCI Wiki.
  • Do the PHPCI tests pass?

Detailed description of change:

  • changed regex for correct parse ports and vendors starting with number .
  • added 2 tests for parsing gitlab ssh address.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant