Merge pull request #1482 from dandi/bf-1481

BF: use correct variable in exception upon unknown how to handle value of "species"

Author: yarikoptic

dandi/metadata/util.py

@@ -474,7 +474,7 @@ def extract_species(metadata: dict) -> models.SpeciesType | None:
                     break
         if value_id is None:
             raise ValueError(
-                f"Cannot interpret species field: {value}. Please "
+                f"Cannot interpret species field: {value_orig}. Please "
                 "contact help@dandiarchive.org to add your species. "
                 "You can also put the entire url from NCBITaxon "
                 "(http://www.ontobee.org/ontology/NCBITaxon) into "

dandi/tests/test_metadata.py

@@ -513,6 +513,12 @@ def test_species():
     }
 
 
+def test_extract_unknown_species():
+    with pytest.raises(ValueError) as excinfo:
+        extract_species({"species": "mumba-jumba"})
+    assert str(excinfo.value).startswith("Cannot interpret species field: mumba-jumba")
+
+
 def test_species_map():
     # all alternative names should be lower case
     for common_names, *_ in species_map: