fix: resolve lint (E402) and typing errors for dandischema compat

Move _SCHEMA_BAREASSET_HAS_DATASTANDARD guard block after all imports
to fix E402.  Use getattr/setattr for dataStandard access and
type: ignore[call-arg] for StandardsType(version=...) to satisfy
mypy against released dandischema that lacks these fields.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: yarikoptic

dandi/files/bases.py

@@ -21,20 +21,6 @@
 from dandischema.models import StandardsType, get_schema_version, nwb_standard
 from packaging.version import Version
 from pydantic import ValidationError
-
-# True when the installed dandischema exposes the per-asset dataStandard field
-# and related StandardsType enhancements (version, extensions).  All these
-# fields ship together starting with dandischema 0.12.2.
-# TODO: remove this guard (and all branches that check it) once the minimum
-# required dandischema version is >= 0.12.2.
-_SCHEMA_BAREASSET_HAS_DATASTANDARD = "dataStandard" in BareAsset.model_fields
-if not _SCHEMA_BAREASSET_HAS_DATASTANDARD and Version(
-    dandischema.__version__
-) >= Version("0.12.2"):
-    raise RuntimeError(
-        f"dandischema {dandischema.__version__} should have "
-        f"'dataStandard' field on BareAsset"
-    )
 from pydantic_core import ErrorDetails
 import requests
 
@@ -55,6 +41,20 @@
     Validator,
 )
 
+# True when the installed dandischema exposes the per-asset dataStandard field
+# and related StandardsType enhancements (version, extensions).  All these
+# fields ship together starting with dandischema 0.12.2.
+# TODO: remove this guard (and all branches that check it) once the minimum
+# required dandischema version is >= 0.12.2.
+_SCHEMA_BAREASSET_HAS_DATASTANDARD = "dataStandard" in BareAsset.model_fields
+if not _SCHEMA_BAREASSET_HAS_DATASTANDARD and Version(
+    dandischema.__version__
+) >= Version("0.12.2"):
+    raise RuntimeError(
+        f"dandischema {dandischema.__version__} should have "
+        f"'dataStandard' field on BareAsset"
+    )
+
 lgr = dandi.get_logger()
 
 # TODO -- should come from schema.  This is just a simplistic example for now
@@ -534,16 +534,18 @@ def get_metadata(
                 nwb_exts = {}
             if nwb_exts:
                 kwargs["extensions"] = [
-                    StandardsType(name=name, version=ver).model_dump(
+                    StandardsType(name=name, version=ver).model_dump(  # type: ignore[call-arg]
                         mode="json", exclude_none=True
                     )
                     for name, ver in sorted(nwb_exts.items())
                 ]
             nwb = StandardsType(**kwargs)
-            if metadata.dataStandard is None:
-                metadata.dataStandard = [nwb]
-            elif nwb not in metadata.dataStandard:
-                metadata.dataStandard.append(nwb)
+            # TODO: use metadata.dataStandard directly once min dandischema >= 0.12.2
+            cur = getattr(metadata, "dataStandard", None)
+            if cur is None:
+                setattr(metadata, "dataStandard", [nwb])
+            elif nwb not in cur:
+                cur.append(nwb)
         return metadata
 
     # TODO: @validate_cache.memoize_path

dandi/files/bids.py

@@ -18,10 +18,15 @@
 import dandi
 from dandi.bids_validator_deno import bids_validate
 
-from .bases import GenericAsset, LocalFileAsset, NWBAsset, _SCHEMA_BAREASSET_HAS_DATASTANDARD
+from .bases import (
+    _SCHEMA_BAREASSET_HAS_DATASTANDARD,
+    GenericAsset,
+    LocalFileAsset,
+    NWBAsset,
+)
 
 if _SCHEMA_BAREASSET_HAS_DATASTANDARD:
-    from dandischema.models import hed_standard
+    from dandischema.models import hed_standard  # type: ignore[attr-defined]
 else:
     hed_standard = None  # type: ignore[assignment]
 from .zarr import ZarrAsset
@@ -42,7 +47,7 @@
 
 
 def _add_standard(
-    metadata,  # type: ignore[no-untyped-def]
+    metadata: BareAsset,
     standard_dict: dict,
     version: str | None = None,
 ) -> None:
@@ -53,10 +58,12 @@ def _add_standard(
     if version:
         kwargs["version"] = version
     standard = StandardsType(**kwargs)
-    if metadata.dataStandard is None:
-        metadata.dataStandard = [standard]
-    elif standard not in metadata.dataStandard:
-        metadata.dataStandard.append(standard)
+    # TODO: use metadata.dataStandard directly once min dandischema >= 0.12.2
+    cur = getattr(metadata, "dataStandard", None)
+    if cur is None:
+        setattr(metadata, "dataStandard", [standard])
+    elif standard not in cur:
+        cur.append(standard)
 
 
 @dataclass
@@ -260,10 +267,8 @@ def get_metadata(
                         lib_name, lib_ver = str(entry).split(":", 1)
                     else:
                         lib_name, lib_ver = str(entry), None
-                    ext = StandardsType(name=lib_name, version=lib_ver)
-                    extensions.append(
-                        ext.model_dump(mode="json", exclude_none=True)
-                    )
+                    ext = StandardsType(name=lib_name, version=lib_ver)  # type: ignore[call-arg]
+                    extensions.append(ext.model_dump(mode="json", exclude_none=True))
                 if extensions:
                     kwargs["extensions"] = extensions
             _add_standard(metadata, kwargs)

dandi/tests/test_files.py

@@ -17,7 +17,6 @@
 from ..consts import ZARR_MIME_TYPE, dandiset_metadata_file
 from ..dandiapi import AssetType, RemoteZarrAsset
 from ..exceptions import UnknownAssetError
-from ..files.bases import _SCHEMA_BAREASSET_HAS_DATASTANDARD
 from ..files import (
     BIDSDatasetDescriptionAsset,
     DandisetMetadataFile,
@@ -31,6 +30,7 @@
     dandi_file,
     find_dandi_files,
 )
+from ..files.bases import _SCHEMA_BAREASSET_HAS_DATASTANDARD
 
 lgr = get_logger()
 
@@ -684,7 +684,9 @@ def test_hed_library_schemas_as_extensions(self, tmp_path: Path) -> None:
         )
         metadata = asset.get_metadata()
         hed_standards = [
-            s for s in (metadata.dataStandard or [])
+            # TODO: use metadata.dataStandard directly once min dandischema >= 0.12.2
+            s
+            for s in (getattr(metadata, "dataStandard", None) or [])
             if s.name == "Hierarchical Event Descriptors (HED)"
         ]
         assert len(hed_standards) == 1