Don't re-queue undetermined IPs in update_ip_to_region_codes#275
Merged
Conversation
Previously, IPs stored as "undetermined" (API quota exceeded) were excluded from ip_to_determined_region and re-entered ips_to_update on every run, wasting batch slots that should go to genuinely new IPs. Now any IP already present in the cache (regardless of value) is skipped. The existing refresh command handles periodic re-querying of old entries. https://claude.ai/code/session_011P2oXRraRrd1Yg7i7TVWiK
CodyCBakerPhD
commented
Jun 16, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #275 +/- ##
==========================================
+ Coverage 73.96% 74.75% +0.78%
==========================================
Files 40 40
Lines 1571 1620 +49
==========================================
+ Hits 1162 1211 +49
Misses 409 409
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"undetermined"(API quota exceeded) were re-queued on every run, wasting batch slots that should go to genuinely new IPsrefreshcommand handles periodic re-querying of stale entries on a 90-day cycleTest plan
--batch-limit 1no longer re-processes IPs markedundeterminedin the previous runhttps://claude.ai/code/session_011P2oXRraRrd1Yg7i7TVWiK