Potential fix for code scanning alert no. 15: Workflow does not contain permissions#281
Merged
Conversation
…in permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #281 +/- ##
==========================================
+ Coverage 73.96% 74.75% +0.78%
==========================================
Files 40 40
Lines 1571 1620 +49
==========================================
+ Hits 1162 1211 +49
Misses 409 409
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
CodyCBakerPhD
marked this pull request as ready for review
June 16, 2026 19:47
CodyCBakerPhD
added a commit
that referenced
this pull request
Jun 16, 2026
Mirrors the fix from PR #281 (testing.yml) across all remaining workflow files. Docker image workflows also get packages: write since they push to GHCR. https://claude.ai/code/session_017m4JYyCuytuMjwKakTqyT3 Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/dandi/s3-log-extraction/security/code-scanning/15
Add an explicit
permissionsblock to the workflow soGITHUB_TOKENis restricted.Best fix here: set workflow-level permissions right after
on:/workflow_calland beforeenvso all jobs inherit it unless overridden.For this workflow, minimal required permission is:
contents: readEdit file:
.github/workflows/testing.ymlon.workflow_call.secretssection (after line 8 in the snippet), beforeenv:.No imports, methods, or dependencies are needed.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.