Skip to content

Read.netcdf to image classes#121

Open
joshqsumner wants to merge 8 commits intomainfrom
read.netcdf-to-image-classes
Open

Read.netcdf to image classes#121
joshqsumner wants to merge 8 commits intomainfrom
read.netcdf-to-image-classes

Conversation

@joshqsumner
Copy link
Copy Markdown
Contributor

@joshqsumner joshqsumner commented Apr 7, 2026

Describe your changes
Updated read.netcdf to read to GEO and DSM classes through a new helper _read_to_class which handles the logic for picking between DSM and GEO (this was simpler than finding a grayscale netcdf file).

Type of update
This is a feature update

Associated issues
Closes #110

Additional context
Follows #120

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv-geospatial/mkdocs.yml
  • Changes to function input/output signatures added to changelog.md
  • Code reviewed
  • PR approved

@joshqsumner joshqsumner added the merge in order Dependent on another PR label Apr 7, 2026
@deepsource-io
Copy link
Copy Markdown

deepsource-io Bot commented Apr 7, 2026

DeepSource Code Review

We reviewed changes in b6e6c2e...335ade8 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Coverage  

Code Review Summary

Analyzer Status Updated (UTC) Details
Python Apr 8, 2026 4:30p.m. Review ↗
Test coverage Apr 8, 2026 4:31p.m. Review ↗

Code Coverage Summary

Language Line Coverage (New Code) Line Coverage (Overall)
Aggregate
100%
100%
Python
100%
100%

➟ Additional coverage metrics may have been reported. See full coverage report ↗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge in order Dependent on another PR ready to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Modify all functions to use Image/GEO/DSM subclasses instead of spectral objects

2 participants