Skip to content

Fix warnings if YYJSON_MSC_VER doesn't exist#674

Merged
danielaparker merged 2 commits into
danielaparker:masterfrom
JohannAnhofer:master
Jan 9, 2026
Merged

Fix warnings if YYJSON_MSC_VER doesn't exist#674
danielaparker merged 2 commits into
danielaparker:masterfrom
JohannAnhofer:master

Conversation

@JohannAnhofer
Copy link
Copy Markdown
Contributor

Fixes two more warnings

@danielaparker
Copy link
Copy Markdown
Owner

danielaparker commented Jan 9, 2026

Indeed YYJSON_MSC_VER doesn't exist, not in jsoncons, it's a macro from the "C" library yyjson. I believe it unintentionally ended up in compiler_support.hpp as a result of some experimental work inspired by yyjson, but neither macro that references it, JSONCONS_NOINLINE or JSONCONS_ALIGN, is used in the existing code base. Instead of the fix, can you update the PR to remove those two macros instead?

Thanks for spotting this.

@JohannAnhofer
Copy link
Copy Markdown
Contributor Author

ok, removing dead code is always a good idea.

@danielaparker danielaparker merged commit 294c7de into danielaparker:master Jan 9, 2026
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants