Fix warnings if YYJSON_MSC_VER doesn't exist#674
Merged
Conversation
Owner
|
Indeed YYJSON_MSC_VER doesn't exist, not in jsoncons, it's a macro from the "C" library yyjson. I believe it unintentionally ended up in compiler_support.hpp as a result of some experimental work inspired by yyjson, but neither macro that references it, JSONCONS_NOINLINE or JSONCONS_ALIGN, is used in the existing code base. Instead of the fix, can you update the PR to remove those two macros instead? Thanks for spotting this. |
Contributor
Author
|
ok, removing dead code is always a good idea. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two more warnings