optimize semantic_tag::noesc write_string#685
Merged
danielaparker merged 1 commit intoMar 4, 2026
Conversation
This change replaces the per-character loop with a single bulk write: sink_.append(sv.data(), sv.length())
3 tasks
Owner
|
Thanks for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change replaces the per-character loop with a single bulk write: sink_.append(sv.data(), sv.length())
When encoding large JSON strings tagged as semantic_tag::noesc, json_encoder currently writes characters one-by-one via sink_.push_back(*it). This is a hot path for payloads dominated by large base64 fields and causes a noticeable regression versus previous versions.
This gives significant improvement on noesc-heavy DOM->string