Skip to content

JMESPath functions floor and ceil return integer #688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielaparker merged 5 commits into from
Mar 21, 2026
+79 −4
Merged

JMESPath functions floor and ceil return integer #688

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f5dc3b2
function floor and ceil return an integer
Mar 17, 2026
75abe1a
Check if ceil and floor result can safely be cast to int64
Mar 18, 2026
dc52216
Cast int64_t to double before comparing with double
Mar 18, 2026
9d56207
Check if ceil and floor result can safely be cast to int64 - differen…
Mar 19, 2026
c122300
Check if ceil and floor result can safely be cast to int64 - use cons…
Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 29 additions & 4 deletions include/jsoncons_ext/jmespath/jmespath.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1240,6 +1240,9 @@ namespace detail {
template <typename Json>
class jmespath_evaluator
{
static constexpr double max_double_to_int64 = 9223372036854775807.0;
static constexpr double min_double_to_int64 = -9223372036854775808.0;

public:
typedef typename Json::char_type char_type;
typedef typename Json::char_traits_type char_traits_type;
Expand Down Expand Up @@ -1387,11 +1390,22 @@ namespace detail {
case json_type::uint64:
case json_type::int64:
{
return *context.create_json(arg0.template as<double>());
return arg0;
}
case json_type::float64:
{
return *context.create_json(std::ceil(arg0.template as<double>()));
auto dbl0 = arg0.template as<double>();
if (!std::isfinite(dbl0)) {
ec = jmespath_errc::invalid_type;
return context.null_value();
}
dbl0 = std::ceil(dbl0);
if (dbl0 >= min_double_to_int64 && dbl0 <= max_double_to_int64) {
return *context.create_json(static_cast<int64_t>(dbl0));
}
else {
return *context.create_json(dbl0);
}
}
default:
ec = jmespath_errc::invalid_type;
Expand Down Expand Up @@ -1523,11 +1537,22 @@ namespace detail {
case json_type::uint64:
case json_type::int64:
{
return *context.create_json(arg0.template as<double>());
return *context.create_json(arg0);
}
case json_type::float64:
{
return *context.create_json(std::floor(arg0.template as<double>()));
auto dbl0 = arg0.template as<double>();
if (!std::isfinite(dbl0)) {
ec = jmespath_errc::invalid_type;
return context.null_value();
}
dbl0 = std::floor(dbl0);
if (dbl0 >= min_double_to_int64 && dbl0 <= max_double_to_int64) {
return *context.create_json(static_cast<int64_t>(dbl0));
}
else {
return *context.create_json(dbl0);
}
}
default:
ec = jmespath_errc::invalid_type;
Expand Down
50 changes: 50 additions & 0 deletions test/jmespath/input/test.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,56 @@
"result": { "value": false }
}
]
},
{
"given": {},
"cases": [
{
"comment": "Floor function applied to a float should return integer",
"expression": "to_string(floor(`3.7`))",
"result": "3"
},
{
"comment": "Floor function applied to a negative float should return integer",
"expression": "to_string(floor(`-3.7`))",
"result": "-4"
},
{
"comment": "Floor function applied to an integer should return the same integer",
"expression": "to_string(floor(`3`))",
"result": "3"
},
{
"comment": "Floor function applied to a negative integer should return the same integer",
"expression": "to_string(floor(`-3`))",
"result": "-3"
},
{
"comment": "Ceil function applied to a float should return integer",
"expression": "to_string(ceil(`3.7`))",
"result": "4"
},
{
"comment": "Ceil function applied to a negative float should return integer",
"expression": "to_string(ceil(`-3.7`))",
"result": "-3"
},
{
"comment": "Ceil function applied to an integer should return the same integer",
"expression": "to_string(ceil(`3`))",
"result": "3"
},
{
"comment": "Ceil function applied to a negative integer should return the same integer",
"expression": "to_string(ceil(`-3`))",
"result": "-3"
},
{
"comment": "Ceil function applied to a large double not in int64_t range should return as double",
"expression": "ceil(`1e20`)",
"result": 1e20
}
]
}
]