Fix bad multiplier when writing some BSON datetimes#700
Merged
Conversation
Fix that basic_bson_encoder::visit_uint64 converted epoch_nano-tagged integers to seconds, not milliseconds, before serializing as a BSON datetime. The resulting datetime would be much closer to 1970-01-01 than it should. This commit copies the correct behavior from visit_int64 to visit_uint64.
Owner
|
Thanks for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix that
basic_bson_encoder::visit_uint64convertedsemantic_tag::epoch_nano-tagged integers to seconds, not milliseconds, before serializing as a BSON datetime. The resulting datetime would be much closer to 1970-01-01 (the Unix epoch) than it should. This commit copies the correct behavior fromvisit_int64tovisit_uint64.