Don't write extra value after some CBOR epoch timestamps#701
Merged
Conversation
Fix that `epoch_milli`- and `epoch_nano`-tagged integers serialized to too many values in CBOR: a CBOR semantic tag of 1 (expected), a float64 number of seconds since the epoch (expected), and then the integer number of milliseconds or nanoseconds (bad). Only the semantic tag and float64 should be written; the trailing integer could wrongly be interpreted as the next key in a map or value in an array. Thanks for your work on the library and your quick response to my last PR.
Owner
|
Thanks for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix that
epoch_milli- andepoch_nano-tagged integers serialized to too many values in CBOR:Only the semantic tag and float64 should be written; the trailing integer could wrongly be interpreted as the next key in a map or value in an array.
Thanks for your work on the library and your quick response to my last pull request.