Block indefinitely waiting for mic permission instead of crash-looping

When mic is denied, poll every 5s forever instead of failing after 30s.
This prevents launchd KeepAlive from restarting the process and spawning
duplicate permission dialogs. The process stays alive and quiet until
the user grants mic access (via the dialog or System Settings).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: danielbodart

src/platform/macos/audio.zig

@@ -64,19 +64,13 @@ pub const AudioCapture = struct {
         // explicitly chose the device.
         const mic_status = if (target != null) @as(c_int, 3) else capsper_mic_permission_status();
         if (mic_status != 3) {
-            // Not yet authorized: request permission (or poll if denied).
-            // For notDetermined (0): shows the system permission dialog and blocks.
-            // For denied (2): polls for 30s in case a dialog from a previous
-            //   launch is still visible (launchd restarts race with user clicking Allow).
-            // For restricted (1): polls briefly then fails.
-            if (mic_status == 1) {
-                log.err("Microphone access is restricted by system policy.", .{});
-                return error.AudioInitFailed;
-            }
-            log.info("Requesting microphone permission...", .{});
+            // Not yet authorized — blocks until the user grants permission.
+            // For notDetermined: shows the system dialog and waits.
+            // For denied: polls until granted via System Settings.
+            // Never returns failure except for restricted (system policy).
+            log.info("Waiting for microphone permission...", .{});
             if (capsper_mic_request_permission() == 0) {
-                log.err("Microphone permission denied.", .{});
-                log.err("Grant access in: System Settings → Privacy & Security → Microphone", .{});
+                log.err("Microphone access is restricted by system policy.", .{});
                 return error.AudioInitFailed;
             }
         }

src/platform/macos/mic_permission.m

@@ -10,15 +10,17 @@ int capsper_mic_permission_status(void) {
     return (int)[AVCaptureDevice authorizationStatusForMediaType:AVMediaTypeAudio];
 }
 
-// Blocks until the user responds to the permission dialog.
-// Returns 1 if granted, 0 if denied.
+// Blocks until microphone permission is granted.
 // If status is notDetermined, shows the permission dialog and blocks.
-// If status is denied, polls for up to 30 seconds in case a permission
-// dialog from a previous launch is still visible (launchd restarts can
-// race with the user clicking "Allow").
+// If status is denied, blocks and polls indefinitely — the user may be
+// responding to a dialog from a previous launch, or may grant access
+// via System Settings. Either way, we wait rather than crash and restart
+// (which would spawn duplicate permission dialogs via launchd KeepAlive).
+// Returns 1 if granted, 0 only for restricted (system policy, no recovery).
 int capsper_mic_request_permission(void) {
     AVAuthorizationStatus status = [AVCaptureDevice authorizationStatusForMediaType:AVMediaTypeAudio];
     if (status == AVAuthorizationStatusAuthorized) return 1;
+    if (status == AVAuthorizationStatusRestricted) return 0;
 
     if (status == AVAuthorizationStatusNotDetermined) {
         __block int granted = 0;
@@ -28,19 +30,17 @@ int capsper_mic_request_permission(void) {
             dispatch_semaphore_signal(sem);
         }];
         dispatch_semaphore_wait(sem, DISPATCH_TIME_FOREVER);
-        return granted;
+        if (granted) return 1;
+        // User denied — fall through to polling below
     }
 
-    // Status is denied or restricted. Poll briefly in case the user is
-    // responding to a mic dialog from a previous launch attempt — launchd's
-    // KeepAlive restarts can overlap with a pending permission prompt.
-    for (int i = 0; i < 15; i++) {
-        [NSThread sleepForTimeInterval:2.0];
+    // Denied: poll every 5s until granted. The user can grant access via
+    // System Settings → Privacy & Security → Microphone at any time.
+    while (1) {
+        [NSThread sleepForTimeInterval:5.0];
         if ([AVCaptureDevice authorizationStatusForMediaType:AVMediaTypeAudio]
                 == AVAuthorizationStatusAuthorized) {
             return 1;
         }
     }
-    return 0;
 }
-