fix(version-picker): disable versions missing from RomM#1575
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What this is
PR 3 of #1570. Retained local ROM rows no longer masquerade as live, selectable versions after RomM drops their ids. Availability is recomputed whenever the Game Page lazily loads the version list; it is never persisted.
What changed
get_romprobes. If the bound id itself returns 404, every other local member is probed individually.RommNotFoundErrormarks a versionvanished; every non-404 failure fails open.No longer available on RomM, disabled, and excluded from Default ranking.vanishedremains separate fromswitchable, preserving sibling-group membership semantics.bound_vanished: truewithout reporting RomM offline or updating the global connection state.SavesTabexcludes vanished versions from its stranded-save advice while continuing to inspect live inactive installs.not_foundinstead ofserver_unreachable; artwork remains data-only and is not used as liveness evidence.The version-switch commit guard and deletion/purge behavior remain in PRs 4 and 5.
Safety
Liveness probes use the existing three-second
request_oncepath on the executor fan-out, so they neither retry nor block the event loop. Direct sibling presence is a positive server statement; absence alone never proves disappearance because sibling groups can be transitive.A restored database or visibility change can make the same id available again. The next list load recomputes the result and removes
vanishedautomatically.Docs
Updated the backend and Steam-shortcut architecture pages plus the managing-games and save-sync user guides. Frozen ADR history remains unchanged.
Verification
mise run gatepassed on the final code state:The subsequent documentation wording correction passed focused Markdown formatting, link, whitespace, backend, frontend, and 404-classification checks. Final review found no remaining issues.
On-device verification
Open a Game Page whose shortcut is bound to a RomM id that was removed while a replacement version remains in the local sibling group. The page should render without waiting for liveness probes; the removed version should remain visible but disabled, the live replacement should remain selectable, and RomM must not be reported offline.
Closes part of #1570.