fix: resolve all ruff lint errors

- B904: Add 'from None' to HTTPException raises in except clauses
- B008: Use Annotated type aliases for File() and Security() defaults

Author: danielcopper

app/api/routes/edit.py

@@ -1,7 +1,7 @@
 import base64
 import logging
 from pathlib import Path
-from typing import Literal
+from typing import Annotated, Literal
 
 from fastapi import APIRouter, Depends, File, Form, HTTPException, UploadFile
 
@@ -18,6 +18,10 @@
 
 router = APIRouter(prefix="/edit", tags=["Image Editing"])
 
+# Type aliases for form fields
+ImageFile = Annotated[UploadFile | None, File(description="Image file to edit")]
+MaskFile = Annotated[UploadFile | None, File(description="Mask image (transparent areas will be edited)")]
+
 
 @router.post(
     "",
@@ -36,9 +40,9 @@ async def edit_image(
         "litellm", description="Provider to use for editing"
     ),
     model: str | None = Form(None, description="Model ID (optional, uses default if not set)"),
-    image: UploadFile | None = File(None, description="Image file to edit"),
+    image: ImageFile = None,
     image_url: str | None = Form(None, description="URL to existing image (alternative to upload)"),
-    mask: UploadFile | None = File(None, description="Mask image (transparent areas will be edited)"),
+    mask: MaskFile = None,
     n: int = Form(1, ge=1, le=4, description="Number of variations to generate"),
     response_format: Literal["url", "base64", "markdown"] = Form(
         "url", description="Response format"
@@ -63,10 +67,10 @@ async def edit_image(
         else:
             image_bytes = await storage_service.get_image(image_url)
     except FileNotFoundError as e:
-        raise HTTPException(status_code=404, detail=str(e))
+        raise HTTPException(status_code=404, detail=str(e)) from None
     except Exception as e:
         logger.error(f"Failed to load image: {e}")
-        raise HTTPException(status_code=400, detail=f"Failed to load image: {str(e)}")
+        raise HTTPException(status_code=400, detail=f"Failed to load image: {str(e)}") from None
 
     # Load mask bytes if provided
     mask_bytes = None
@@ -81,7 +85,7 @@ async def edit_image(
     try:
         service = _get_service(provider)
     except ValueError as e:
-        raise HTTPException(status_code=400, detail=str(e))
+        raise HTTPException(status_code=400, detail=str(e)) from None
 
     # Edit image
     try:
@@ -104,7 +108,7 @@ async def edit_image(
             )
     except Exception as e:
         logger.error(f"Edit failed: {e}", exc_info=True)
-        raise HTTPException(status_code=500, detail=f"Edit failed: {str(e)}")
+        raise HTTPException(status_code=500, detail=f"Edit failed: {str(e)}") from None
 
     if not urls:
         raise HTTPException(status_code=500, detail="No images generated")

app/api/routes/generate.py

@@ -49,7 +49,7 @@ async def generate_image(request: ImageRequest, _: None = Depends(verify_token))
     try:
         service = _get_service(request.provider)
     except ValueError as e:
-        raise HTTPException(status_code=400, detail=str(e))
+        raise HTTPException(status_code=400, detail=str(e)) from None
 
     # Generate images
     try:
@@ -62,7 +62,7 @@ async def generate_image(request: ImageRequest, _: None = Depends(verify_token))
         )
     except Exception as e:
         logger.error(f"Generation failed: {e}", exc_info=True)
-        raise HTTPException(status_code=500, detail=f"Generation failed: {str(e)}")
+        raise HTTPException(status_code=500, detail=f"Generation failed: {str(e)}") from None
 
     # Return first URL (or could return all URLs)
     if not urls:
@@ -152,7 +152,7 @@ async def generate_image_stream(request: ImageRequest, _: None = Depends(verify_
     try:
         service = _get_service(request.provider)
     except ValueError as e:
-        raise HTTPException(status_code=400, detail=str(e))
+        raise HTTPException(status_code=400, detail=str(e)) from None
 
     # Return SSE stream
     return StreamingResponse(
@@ -198,7 +198,7 @@ async def generate_image_preview(request: ImageRequest, _: None = Depends(verify
     try:
         service = _get_service(request.provider)
     except ValueError as e:
-        raise HTTPException(status_code=400, detail=str(e))
+        raise HTTPException(status_code=400, detail=str(e)) from None
 
     # Generate images
     try:
@@ -211,7 +211,7 @@ async def generate_image_preview(request: ImageRequest, _: None = Depends(verify
         )
     except Exception as e:
         logger.error(f"Generation failed: {e}", exc_info=True)
-        raise HTTPException(status_code=500, detail=f"Generation failed: {str(e)}")
+        raise HTTPException(status_code=500, detail=f"Generation failed: {str(e)}") from None
 
     if not urls:
         raise HTTPException(status_code=500, detail="No images generated")

app/api/routes/models.py

@@ -48,11 +48,13 @@ async def list_models(_: None = Depends(verify_token)) -> ModelListResponse:
     include_in_schema=False,  # Admin operation, not for function calling
 )
 async def refresh_models(
-    request: ModelRefreshRequest = ModelRefreshRequest(), _: None = Depends(verify_token)
+    request: ModelRefreshRequest | None = None, _: None = Depends(verify_token)
 ) -> ModelListResponse:
     """
     Refresh model list from LiteLLM.
     """
+    if request is None:
+        request = ModelRefreshRequest()
     logger.info(f"Refreshing models (force={request.force})")
 
     models = await model_registry.load_models(force=request.force)

app/core/security.py

@@ -1,14 +1,18 @@
+from typing import Annotated
 
-from fastapi import HTTPException, Security, status
+from fastapi import Depends, HTTPException, status
 from fastapi.security import HTTPAuthorizationCredentials, HTTPBearer
 
 from app.core.config import settings
 
 security = HTTPBearer(auto_error=False)
 
+# Type alias for security dependency
+SecurityCredentials = Annotated[HTTPAuthorizationCredentials | None, Depends(security)]
+
 
 async def verify_token(
-    credentials: HTTPAuthorizationCredentials | None = Security(security),
+    credentials: SecurityCredentials,
 ) -> None:
     """
     Verify Bearer token if configured.