Debug Code and Resolve Existing Problems#107
Closed
danieleades wants to merge 2 commits into
Closed
Conversation
The encoder's flush function was using an incorrect condition for determining which final bit to emit. After normalization, the range [low, high] straddles the midpoint, so the flush logic should check if low < half() to decide whether to emit 0 or 1. Previously used: low <= quarter() Corrected to: low < half() This aligns with standard arithmetic coding flush logic and ensures correct encoding of the final bits. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
The previous commit incorrectly changed the condition to use half() instead of quarter(). The actual bug was the comparison operator. After the E2/E3 normalization loop exits, we know: - low < quarter OR high >= three_quarter When low == quarter exactly, we must have high >= three_quarter (otherwise the loop would continue). This places us in the upper region, so we should emit 1, not 0. The fix: change <= to < to properly handle the boundary case. Before: if self.state.low <= self.state.quarter() After: if self.state.low < self.state.quarter() This reverts the half() change and fixes the actual comparison bug. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #107 +/- ##
=======================================
Coverage 75.69% 75.69%
=======================================
Files 11 11
Lines 572 572
=======================================
Hits 433 433
Misses 139 139 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The encoder's flush function was using an incorrect condition for determining which final bit to emit. After normalization, the range [low, high] straddles the midpoint, so the flush logic should check if low < half() to decide whether to emit 0 or 1.
Previously used: low <= quarter()
Corrected to: low < half()
This aligns with standard arithmetic coding flush logic and ensures correct encoding of the final bits.
🤖 Generated with Claude Code