feat(validation): add machine-readable Code and Params to ErrorDetail#1000
Open
Micaso wants to merge 1 commit intodanielgtaylor:mainfrom
Open
feat(validation): add machine-readable Code and Params to ErrorDetail#1000Micaso wants to merge 1 commit intodanielgtaylor:mainfrom
Micaso wants to merge 1 commit intodanielgtaylor:mainfrom
Conversation
Validation errors previously exposed only a human-readable Message string, making it impossible to programmatically handle specific error types without fragile string parsing. Add Code (snake_case identifier) and Params (constraint parameters) fields to ErrorDetail, along with matching Code* constants in the validation package. All internal call sites are migrated to the new ValidateResult.AddCode() method which threads the code and params through. Both fields are omitempty and fully backwards-compatible. Consumers can now switch on detail.Code and read structured params (e.g. allowed enum values, numeric bounds, required property names) without touching Message. Closes danielgtaylor#999
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1000 +/- ##
==========================================
+ Coverage 93.07% 93.08% +0.01%
==========================================
Files 23 23
Lines 4780 4789 +9
==========================================
+ Hits 4449 4458 +9
Misses 271 271
Partials 60 60 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validation errors previously exposed only a human-readable Message string,
making it impossible to programmatically handle specific error types without
fragile string parsing.
Add Code (snake_case identifier) and Params (constraint parameters) fields
to ErrorDetail, along with matching Code* constants in the validation package.
All internal call sites are migrated to the new ValidateResult.AddCode()
method which threads the code and params through.
Both fields are omitempty and fully backwards-compatible. Consumers can now
switch on detail.Code and read structured params (e.g. allowed enum values,
numeric bounds, required property names) without touching Message.
Closes #999