feat(sse): allow specifying the schema for SSE operations#1061
Open
lsdch wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1061 +/- ##
=======================================
Coverage 93.15% 93.16%
=======================================
Files 23 23
Lines 5012 5016 +4
=======================================
+ Hits 4669 4673 +4
Misses 277 277
Partials 66 66 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
… already set in the user-provided operation
lsdch
force-pushed
the
sse-schema-override
branch
from
420777e to
03561fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1043
OpenAPI tools may have different interpretations of the SSE specification (which is kinda fuzzy as far as i can tell) and make opinionated decisions that may not be compatible across tools (see #1043 for an example).
This PR allows users to circumvent this issue by explicitly setting the response schema for an SSE operation.