Conversation
|
Hey @sharath-09, thanks for this! I do have a few notes to clarify; why have you changed the context usage to use pointers when it wasn't necessary or beneficial to do so before? Is this a requirement for v5? Why rename Additionally, please revert the dependency changes, particularly the upgraded Go version. |
|
Hey @sharath-09! Have you had a chance to review my comments? We've updated Huma to use Go 1.25, and have updated all other dependencies :) |
|
Hey @wolveix apologies for the delay, life got in the way. I was initially confused about how to approach the versioning bump, but seems like it's been resolved in #962. Thanks for the feedback, I have used pointers, as this is a major breaking change introduced in Echov5 - https://github.com/labstack/echo/blob/v5.0.0/API_CHANGES_V5.md. The context returned is a concrete struct rather than an interface. I have pulled the latest commits, renamed middleware to middlewares, and made sure it passes tests. Please let me know if you have any additional feedback. If you'd like me to use dedicated files for echov4 as in #962, I can do so. Thanks! |
|
@wolveix I have retained Echo v4 support in a separate file, as echo v4 support drops in 31/12/2026. Once this date passes, it should be trivial to drop v4 support. |
|
Hey @wolveix Just wanted to check in and see if there's anything blocking this. Thanks |
This PR uplifts the humaecho adapter to support the new echov5 standard. Happy to hear feedback. Addresses Issue #957