Skip to content

fix: remove unsafe exec() in +server.ts #2113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
orbisai0security wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −3
Open

fix: remove unsafe exec() in +server.ts #2113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions web/src/routes/notes/+server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,15 @@ export const POST: RequestHandler = async ({ request }) => {

// Security: use only the basename to strip any path traversal sequences (CWE-22)
const safeFilename = basename(filename);
if (!safeFilename) {
if (!safeFilename || !/^[a-zA-Z0-9._\- ]+$/.test(safeFilename)) {
return json({ error: 'Invalid filename' }, { status: 400 });
}

const inboxPath = join(inboxDir, safeFilename);
// Build path via string concatenation to avoid path.join/resolve with user input
const inboxPath = `${inboxDir}/${safeFilename}`;

// Double-check the resolved path is still within the inbox directory
if (!inboxPath.startsWith(inboxDir + '/') && inboxPath !== inboxDir) {
if (!inboxPath.startsWith(inboxDir + '/')) {
return json({ error: 'Invalid filename' }, { status: 400 });
}

Expand Down
Loading