Commit f2cfa46
committed
docs(helm): correct the metrics bindAddress override note
The earlier note suggested keeping `service.port` aligned with a
runtime override of `METRICS_BIND_ADDRESS`, but `service.port` is the
cluster-facing front-door port and has no effect on the Service
backend. The Service `targetPort` and the pod `containerPort` are both
derived from `bindAddress` at template time, so overriding the env var
via `controller.env` cannot move the rendered Service at all — that
operational consequence is what the comment now states, with
`bindAddress` flagged as the only chart-side knob that moves the
listener and the Service together.
Addresses review feedback on kagent-dev#1803.
Signed-off-by: Daniel Orbach <ddorbach@gmail.com>1 parent 18826c4 commit f2cfa46
1 file changed
Lines changed: 8 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
228 | 228 | | |
229 | 229 | | |
230 | 230 | | |
231 | | - | |
232 | | - | |
233 | | - | |
234 | | - | |
235 | | - | |
236 | | - | |
237 | | - | |
238 | | - | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
239 | 239 | | |
240 | 240 | | |
241 | 241 | | |
| |||
0 commit comments