refactor: add checkFetchResponse after each doFetch

revert status code handling code

Author: danielpeintner

packages/binding-http/src/http-client-impl.ts

@@ -128,8 +128,6 @@ export default class HttpClient implements ProtocolClient {
 
         const result = await this.doFetch(request);
 
-        this.checkFetchResponse(result);
-
         debug(`HttpClient received headers: ${JSON.stringify(result.headers.raw())}`);
         debug(`HttpClient received Content-Type: ${result.headers.get("content-type")}`);
 
@@ -154,8 +152,6 @@ export default class HttpClient implements ProtocolClient {
 
         debug(`HttpClient received ${result.status} from ${result.url}`);
 
-        this.checkFetchResponse(result);
-
         debug(`HttpClient received headers: ${JSON.stringify(result.headers.raw())}`);
     }
 
@@ -218,8 +214,6 @@ export default class HttpClient implements ProtocolClient {
         debug(`HttpClient received ${result.status} from ${request.url}`);
         debug(`HttpClient received Content-Type: ${result.headers.get("content-type")}`);
 
-        this.checkFetchResponse(result);
-
         // in browsers node-fetch uses the native fetch, which returns a ReadableStream
         // not complaint with node. Therefore we have to force the conversion here.
         const body = ProtocolHelpers.toNodeStream(result.body as Readable);
@@ -432,14 +426,13 @@ export default class HttpClient implements ProtocolClient {
 
         if (HttpClient.isOAuthTokenExpired(result, this.credential)) {
             this.credential = await (this.credential as OAuthCredential).refreshToken();
-            return await this._fetch(await this.credential.sign(request));
-        } else if (result.status === 401) {
-            throw new Error("Client error: Unauthorized");
-        } else if (result.status >= 400) {
-            // report generic error
-            throw new Error(`request to ${request.url} failed, reason: HTTP status result ${result.status} `);
+            const resultAuth = await this._fetch(await this.credential.sign(request));
+            this.checkFetchResponse(resultAuth);
+            return resultAuth;
         }
 
+        this.checkFetchResponse(result);
+
         return result;
     }