Skip to content

Swift 4.2 support.#57

Open
glm4 wants to merge 3 commits into
danielrhodes:masterfrom
glm4:master
Open

Swift 4.2 support.#57
glm4 wants to merge 3 commits into
danielrhodes:masterfrom
glm4:master

Conversation

@glm4

@glm4 glm4 commented May 6, 2019

Copy link
Copy Markdown

Migrate swift version to 4.2 in all targets and dependencies.

@anphanngocvn

Copy link
Copy Markdown

@glm4 This latest upgrade doesn't stable. The onReceive callback works sometime (the same issue to version 0.2.4). However if I revert to 0.2.3, then it works very well.

@amakhonin

Copy link
Copy Markdown

@glm4 This latest upgrade doesn't stable. The onReceive callback works sometime (the same issue to version 0.2.4). However if I revert to 0.2.3, then it works very well.

this happens because if let item = idJSON.first { channelIdentifier = item.value as? String } in JSONSerializer, guess we need another fork..

@glm4

glm4 commented Jul 24, 2019

Copy link
Copy Markdown
Author

@glm4 This latest upgrade doesn't stable. The onReceive callback works sometime (the same issue to version 0.2.4). However if I revert to 0.2.3, then it works very well.

I guess that's not in the scope of this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants