Skip to content

Commit 0fcff83

Browse files
authored
Fixing property initializiation order (#245673)
fixing property initializiation order
1 parent 8aead9b commit 0fcff83

3 files changed

Lines changed: 26 additions & 16 deletions

File tree

build/lib/propertyInitOrderChecker.js

Lines changed: 0 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

build/lib/propertyInitOrderChecker.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ const ignored = new Set([
2929
'vs/editor/common/model/tokenizationTextModelPart.ts',
3030
'vs/editor/common/core/textEdit.ts',
3131
'vs/editor/browser/view/viewLayer.ts',
32-
'vs/editor/browser/controller/editContext/textArea/textAreaEditContextInput.ts',
3332
'vs/platform/accessibilitySignal/browser/accessibilitySignalService.ts',
3433
'vs/editor/browser/widget/diffEditor/utils.ts',
3534
'vs/editor/browser/observableCodeEditor.ts',

src/vs/editor/browser/controller/editContext/textArea/textAreaEditContextInput.ts

Lines changed: 26 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -619,19 +619,19 @@ export class TextAreaInput extends Disposable {
619619

620620
export class TextAreaWrapper extends Disposable implements ICompleteTextAreaWrapper {
621621

622-
public readonly onKeyDown = this._register(new DomEmitter(this._actual, 'keydown')).event;
623-
public readonly onKeyPress = this._register(new DomEmitter(this._actual, 'keypress')).event;
624-
public readonly onKeyUp = this._register(new DomEmitter(this._actual, 'keyup')).event;
625-
public readonly onCompositionStart = this._register(new DomEmitter(this._actual, 'compositionstart')).event;
626-
public readonly onCompositionUpdate = this._register(new DomEmitter(this._actual, 'compositionupdate')).event;
627-
public readonly onCompositionEnd = this._register(new DomEmitter(this._actual, 'compositionend')).event;
628-
public readonly onBeforeInput = this._register(new DomEmitter(this._actual, 'beforeinput')).event;
629-
public readonly onInput = <Event<InputEvent>>this._register(new DomEmitter(this._actual, 'input')).event;
630-
public readonly onCut = this._register(new DomEmitter(this._actual, 'cut')).event;
631-
public readonly onCopy = this._register(new DomEmitter(this._actual, 'copy')).event;
632-
public readonly onPaste = this._register(new DomEmitter(this._actual, 'paste')).event;
633-
public readonly onFocus = this._register(new DomEmitter(this._actual, 'focus')).event;
634-
public readonly onBlur = this._register(new DomEmitter(this._actual, 'blur')).event;
622+
public readonly onKeyDown: Event<KeyboardEvent>;
623+
public readonly onKeyPress: Event<KeyboardEvent>;
624+
public readonly onKeyUp: Event<KeyboardEvent>;
625+
public readonly onCompositionStart: Event<CompositionEvent>;
626+
public readonly onCompositionUpdate: Event<CompositionEvent>;
627+
public readonly onCompositionEnd: Event<CompositionEvent>;
628+
public readonly onBeforeInput: Event<InputEvent>;
629+
public readonly onInput: Event<InputEvent>;
630+
public readonly onCut: Event<ClipboardEvent>;
631+
public readonly onCopy: Event<ClipboardEvent>;
632+
public readonly onPaste: Event<ClipboardEvent>;
633+
public readonly onFocus: Event<FocusEvent>;
634+
public readonly onBlur: Event<FocusEvent>; // = this._register(new DomEmitter(this._actual, 'blur')).event;
635635

636636
public get ownerDocument(): Document {
637637
return this._actual.ownerDocument;
@@ -647,12 +647,24 @@ export class TextAreaWrapper extends Disposable implements ICompleteTextAreaWrap
647647
) {
648648
super();
649649
this._ignoreSelectionChangeTime = 0;
650+
this.onKeyDown = this._register(new DomEmitter(this._actual, 'keydown')).event;
651+
this.onKeyPress = this._register(new DomEmitter(this._actual, 'keypress')).event;
652+
this.onKeyUp = this._register(new DomEmitter(this._actual, 'keyup')).event;
653+
this.onCompositionStart = this._register(new DomEmitter(this._actual, 'compositionstart')).event;
654+
this.onCompositionUpdate = this._register(new DomEmitter(this._actual, 'compositionupdate')).event;
655+
this.onCompositionEnd = this._register(new DomEmitter(this._actual, 'compositionend')).event;
656+
this.onBeforeInput = this._register(new DomEmitter(this._actual, 'beforeinput')).event;
657+
this.onInput = <Event<InputEvent>>this._register(new DomEmitter(this._actual, 'input')).event;
658+
this.onCut = this._register(new DomEmitter(this._actual, 'cut')).event;
659+
this.onCopy = this._register(new DomEmitter(this._actual, 'copy')).event;
660+
this.onPaste = this._register(new DomEmitter(this._actual, 'paste')).event;
661+
this.onFocus = this._register(new DomEmitter(this._actual, 'focus')).event;
662+
this.onBlur = this._register(new DomEmitter(this._actual, 'blur')).event;
650663

651664
this._register(this.onKeyDown(() => inputLatency.onKeyDown()));
652665
this._register(this.onBeforeInput(() => inputLatency.onBeforeInput()));
653666
this._register(this.onInput(() => inputLatency.onInput()));
654667
this._register(this.onKeyUp(() => inputLatency.onKeyUp()));
655-
656668
this._register(dom.addDisposableListener(this._actual, TextAreaSyntethicEvents.Tap, () => this._onSyntheticTap.fire()));
657669
}
658670

0 commit comments

Comments
 (0)