voice - fix some leaks (#245676)

Author: bpasero

src/vs/workbench/api/browser/mainThreadSpeech.ts

@@ -98,7 +98,12 @@ export class MainThreadSpeech implements MainThreadSpeechShape {
 					onDidChange: onDidChange.event,
 					synthesize: async text => {
 						await this.proxy.$synthesizeSpeech(session, text);
-						await raceCancellation(Event.toPromise(Event.filter(onDidChange.event, e => e.status === TextToSpeechStatus.Stopped)), token);
+						const disposable = new DisposableStore();
+						try {
+							await raceCancellation(Event.toPromise(Event.filter(onDidChange.event, e => e.status === TextToSpeechStatus.Stopped, disposable), disposable), token);
+						} finally {
+							disposable.dispose();
+						}
 					}
 				};
 			},

src/vs/workbench/contrib/chat/electron-sandbox/actions/voiceChatActions.ts

@@ -736,7 +736,7 @@ class ChatSynthesizerSessions {
 		const activeSession = this.activeSession = new CancellationTokenSource();
 
 		const disposables = new DisposableStore();
-		activeSession.token.onCancellationRequested(() => disposables.dispose());
+		disposables.add(activeSession.token.onCancellationRequested(() => disposables.dispose()));
 
 		const session = await this.speechService.createTextToSpeechSession(activeSession.token, 'chat');