Merge pull request #44 from danilolutz/release/v1.1.2

Release/v1.1.2

Author: danilolutz

.github/CODE_OF_CONDUCT.md

@@ -3,9 +3,6 @@
 The CoreZipCode code of conduct is derived from the Ruby code of conduct. Any violations of the code of conduct may be reported to Danilo Lutz (danilolutz@gmail.com).
 
 - Participants will be tolerant of opposing views.
-
 - Participants must ensure that their language and actions are free of personal attacks and disparaging personal remarks.
-
 - When interpreting the words and actions of others, participants should always assume good intentions.
-
-- Behavior which can be reasonably considered harassment will not be tolerated.
+- Behavior which can be reasonably considered harassment will not be tolerated.

.github/CONTRIBUTING.md

@@ -17,12 +17,12 @@ However, if you prefer to work with code, simply go to [Cloning the repository](
 
 We follow (or try to) this code architecture principles:
 
-* [OOP](https://en.wikipedia.org/wiki/Object-oriented_programming)
-* [SOLID](https://en.wikipedia.org/wiki/SOLID)
-* [Design Patterns](https://en.wikipedia.org/wiki/Software_design_pattern)
-* [DRY - Don't Repeat Yourself](https://en.wikipedia.org/wiki/Don%27t_repeat_yourself)
-* [KISS - Keep It Simple, Stupid](https://en.wikipedia.org/wiki/KISS_principle)
-* [YAGNI - You Aren't Gonna Need It](https://en.wikipedia.org/wiki/You_aren%27t_gonna_need_it)
+- [OOP](https://en.wikipedia.org/wiki/Object-oriented_programming)
+- [SOLID](https://en.wikipedia.org/wiki/SOLID)
+- [Design Patterns](https://en.wikipedia.org/wiki/Software_design_pattern)
+- [DRY - Don't Repeat Yourself](https://en.wikipedia.org/wiki/Don%27t_repeat_yourself)
+- [KISS - Keep It Simple, Stupid](https://en.wikipedia.org/wiki/KISS_principle)
+- [YAGNI - You Aren't Gonna Need It](https://en.wikipedia.org/wiki/You_aren%27t_gonna_need_it)
 
 ## Reporting an Issue
 
@@ -64,16 +64,16 @@ Maybe you ask yourself: _How can I contribute?_ or _What i can do?_
 
 We'll help you:
 
-* You can implement you favorite zipcode or postcode service and submit to CoreZipCode to be an out-of-the-box service;
-* You can find and fix bugs;
-* Implement openned issues;
-* Improve the CoreZipCode programming.
+- You can implement you favorite zipcode or postcode service and submit to CoreZipCode to be an out-of-the-box service;
+- You can find and fix bugs;
+- Implement openned issues;
+- Improve the CoreZipCode programming.
 
 **Only thing will be required by us to approve the pull requests are the unit tests (with correct code coverage) for the new implementations**.
 
 ## Testing
 
-You already know how it's works, just add you test class in ```CoreZipCode.Tests``` project, implement it, run the unit tests, be sure everything is okay and submit to repo.
+You already know how it's works, just add you test class in `CoreZipCode.Tests` project, implement it, run the unit tests, be sure everything is okay and submit to repo.
 
 To run the tests go to solution folder and execute:
 
@@ -88,6 +88,7 @@ dotnet test CoreZipCode.Tests/CoreZipCode.Tests.csproj -p:CollectCoverage=true -
 
 reportgenerator -reports:CoreZipCode.Tests/.coverage/coverage.opencover.xml -targetdir:CoreZipCode.Tests/.coverage
 ```
+
 And open the file `CoreZipCode.Tests/.coverage/index.htm` to see how the unit tests are affecting the code coverage.
 
 > **NOTE**: You need to have [ReportGenerator](https://www.nuget.org/packages/dotnet-reportgenerator-globaltool) installed. Use the follow command: `dotnet tool install -g dotnet-reportgenerator-globaltool` to install it globally.

CoreZipCode.Tests/Services/Interfaces/ApiHandlerTest.cs

@@ -10,31 +10,30 @@
 
 namespace CoreZipCode.Tests.Services.Interfaces
 {
-    public class ApiHandlerTest
+    public static class ApiHandlerTest
     {
-        private Mock<HttpMessageHandler> _handlerMock;
         private const string SendAsync = "SendAsync";
         private const string MockUri = "https://unit.test.com/";
 
-        private HttpClient ConfigureService(HttpStatusCode statusCode)
+        private static HttpClient ConfigureService(HttpStatusCode statusCode)
         {
-            _handlerMock = new Mock<HttpMessageHandler>();
+            var handlerMock = new Mock<HttpMessageHandler>();
 
-            _handlerMock
+            handlerMock
                 .Protected()
                 .Setup<Task<HttpResponseMessage>>(
                     SendAsync,
                     ItExpr.IsAny<HttpRequestMessage>(),
                     ItExpr.IsAny<CancellationToken>()
                 )
-                .ReturnsAsync(new HttpResponseMessage()
+                .ReturnsAsync(new HttpResponseMessage
                 {
                     StatusCode = statusCode,
                     Content = new StringContent(""),
                 })
                 .Verifiable();
 
-            var httpClient = new HttpClient(_handlerMock.Object)
+            var httpClient = new HttpClient(handlerMock.Object)
             {
                 BaseAddress = new Uri(MockUri),
             };
@@ -43,7 +42,7 @@ private HttpClient ConfigureService(HttpStatusCode statusCode)
         }
 
         [Fact]
-        public void MustCreateANewInstance()
+        public static void MustCreateANewInstance()
         {
             var apiHandler = new ApiHandler();
             var apiHandlerWithHttpClient = new ApiHandler(ConfigureService(HttpStatusCode.OK));
@@ -53,19 +52,19 @@ public void MustCreateANewInstance()
         }
 
         [Fact]
-        public void MustCallApiException()
+        public static void MustCallApiException()
         {
             var apiHandler = new ApiHandler(ConfigureService(HttpStatusCode.BadRequest));
 
-            Assert.Throws<Exception>(() => apiHandler.CallApi(MockUri));
+            Assert.Throws<HttpRequestException>(() => apiHandler.CallApi(MockUri));
         }
 
         [Fact]
-        public async void MustCallApiAsyncException()
+        public static async Task MustCallApiAsyncException()
         {
             var apiHandler = new ApiHandler(ConfigureService(HttpStatusCode.BadRequest));
 
-            await Assert.ThrowsAsync<Exception>(() => apiHandler.CallApiAsync(MockUri));
+            await Assert.ThrowsAsync<HttpRequestException>(() => apiHandler.CallApiAsync(MockUri));
         }
     }
 }

CoreZipCode.Tests/Services/Postcode/PostalpincodeInApi/PostalpincodeInTest.cs

@@ -20,33 +20,32 @@ public class PostalpincodeInTest
         private const string SendAsync = "SendAsync";
         private const string MockUri = "https://unit.test.com/";
 
-        private Mock<HttpMessageHandler> _handlerMock;
         private readonly PostalpincodeIn _service;
 
         public PostalpincodeInTest()
         {
             _service = ConfigureService(ExpectedResponse);
         }
 
-        private PostalpincodeIn ConfigureService(string response)
+        private static PostalpincodeIn ConfigureService(string response)
         {
-            _handlerMock = new Mock<HttpMessageHandler>();
+            var handlerMock = new Mock<HttpMessageHandler>();
 
-            _handlerMock
+            handlerMock
                 .Protected()
                 .Setup<Task<HttpResponseMessage>>(
                     SendAsync,
                     ItExpr.IsAny<HttpRequestMessage>(),
                     ItExpr.IsAny<CancellationToken>()
                 )
-                .ReturnsAsync(new HttpResponseMessage()
+                .ReturnsAsync(new HttpResponseMessage
                 {
                     StatusCode = HttpStatusCode.OK,
                     Content = new StringContent(response),
                 })
                 .Verifiable();
 
-            var httpClient = new HttpClient(_handlerMock.Object)
+            var httpClient = new HttpClient(handlerMock.Object)
             {
                 BaseAddress = new Uri(MockUri),
             };
@@ -55,7 +54,7 @@ private PostalpincodeIn ConfigureService(string response)
         }
 
         [Fact]
-        public void ConstructorTest()
+        public static void ConstructorTest()
         {
             var actual = new PostalpincodeIn();
             Assert.NotNull(actual);
@@ -81,15 +80,15 @@ public void MustGetPostcodesObject()
         }
 
         [Fact]
-        public async void MustGetPostcodesAsync()
+        public async Task MustGetPostcodesAsync()
         {
             var actual = await _service.ExecuteAsync(PostalPinCodeTest);
 
             Assert.Equal(ExpectedResponse, actual);
         }
 
         [Fact]
-        public async void MustGetPostcodesObjectAsync()
+        public async Task MustGetPostcodesObjectAsync()
         {
             var actual = await _service.GetPostcodeAsync<PostalpincodeInModel>(PostalPinCodeTest);
 

CoreZipCode.Tests/Services/Postcode/PostcodesIoApi/PostcodesIoTest.cs

@@ -20,33 +20,32 @@ public class PostcodesIoTest
         private const int ExpectedStatusSuccess = 200;
         private const int ExpectedResultQuality = 1;
 
-        private Mock<HttpMessageHandler> _handlerMock;
         private readonly PostcodesIo _service;
 
         public PostcodesIoTest()
         {
             _service = ConfigureService(ExpectedResponse);
         }
 
-        private PostcodesIo ConfigureService(string response)
+        private static PostcodesIo ConfigureService(string response)
         {
-            _handlerMock = new Mock<HttpMessageHandler>();
+            var handlerMock = new Mock<HttpMessageHandler>();
 
-            _handlerMock
+            handlerMock
                 .Protected()
                 .Setup<Task<HttpResponseMessage>>(
                     SendAsync,
                     ItExpr.IsAny<HttpRequestMessage>(),
                     ItExpr.IsAny<CancellationToken>()
                 )
-                .ReturnsAsync(new HttpResponseMessage()
+                .ReturnsAsync(new HttpResponseMessage
                 {
                     StatusCode = HttpStatusCode.OK,
                     Content = new StringContent(response),
                 })
                 .Verifiable();
 
-            var httpClient = new HttpClient(_handlerMock.Object)
+            var httpClient = new HttpClient(handlerMock.Object)
             {
                 BaseAddress = new Uri(MockUri),
             };
@@ -55,7 +54,7 @@ private PostcodesIo ConfigureService(string response)
         }
 
         [Fact]
-        public void ConstructorTest()
+        public static void ConstructorTest()
         {
             var actual = new PostcodesIo();
             Assert.NotNull(actual);
@@ -81,15 +80,15 @@ public void MustGetPostcodesObject()
         }
 
         [Fact]
-        public async void MustGetPostcodesAsync()
+        public async Task MustGetPostcodesAsync()
         {
             var actual = await _service.ExecuteAsync(PostalPinCodeTest);
 
             Assert.Equal(ExpectedResponse, actual);
         }
 
         [Fact]
-        public async void MustGetPostcodesObjectAsync()
+        public async Task MustGetPostcodesObjectAsync()
         {
             var actual = await _service.GetPostcodeAsync<PostcodesIoModel>(PostalPinCodeTest);
 

CoreZipCode.Tests/Services/ZipCode/SmartyStreetsApi/SmartyStreetsTest.cs

@@ -33,33 +33,32 @@ public class SmartyStreetsTest
 
         private readonly SmartyStreets _service;
         private readonly SmartyStreets _serviceParam;
-        private Mock<HttpMessageHandler> _handlerMock;
 
         public SmartyStreetsTest()
         {
             _service = ConfigureService(ExpectedZipcodeResponse);
             _serviceParam = ConfigureService(ExpectedParamResponse);
         }
 
-        private SmartyStreets ConfigureService(string response)
+        private static SmartyStreets ConfigureService(string response)
         {
-            _handlerMock = new Mock<HttpMessageHandler>();
+            var handlerMock = new Mock<HttpMessageHandler>();
 
-            _handlerMock
+            handlerMock
                 .Protected()
                 .Setup<Task<HttpResponseMessage>>(
                     SendAsync,
                     ItExpr.IsAny<HttpRequestMessage>(),
                     ItExpr.IsAny<CancellationToken>()
                 )
-                .ReturnsAsync(new HttpResponseMessage()
+                .ReturnsAsync(new HttpResponseMessage
                 {
                     StatusCode = HttpStatusCode.OK,
                     Content = new StringContent(response),
                 })
                 .Verifiable();
 
-            var httpClient = new HttpClient(_handlerMock.Object)
+            var httpClient = new HttpClient(handlerMock.Object)
             {
                 BaseAddress = new Uri(MockUri)
             };
@@ -68,14 +67,14 @@ private SmartyStreets ConfigureService(string response)
         }
 
         [Fact]
-        public void ConstructorTest()
+        public static void ConstructorTest()
         {
             var actual = new SmartyStreets(AuthId, AuthToken);
             Assert.NotNull(actual);
         }
 
         [Fact]
-        public void ConstructorNullTest()
+        public static void ConstructorNullTest()
         {
             Assert.Throws<ArgumentNullException>(() => new SmartyStreets(new HttpClient(), AuthId, null));
             Assert.Throws<ArgumentNullException>(() => new SmartyStreets(new HttpClient(), null, AuthToken));
@@ -152,23 +151,23 @@ public void MustThrowTheExceptions()
         }
 
         [Fact]
-        public async void MustGetSingleZipCodeJsonStringAsync()
+        public async Task MustGetSingleZipCodeJsonStringAsync()
         {
             var actual = await _service.ExecuteAsync(ZipCodeTest);
 
             Assert.Equal(ExpectedZipcodeResponse, actual);
         }
 
         [Fact]
-        public async void MustGetListZipCodeJsonStringAsync()
+        public async Task MustGetListZipCodeJsonStringAsync()
         {
             var actual = await _serviceParam.ExecuteAsync(SmartyStreetsParameterState, SmartyStreetsParameterCity, SmartyStreetsParameterStreet);
 
             Assert.Equal(ExpectedParamResponse, actual);
         }
 
         [Fact]
-        public async void MustGetSingleZipCodeObjectAsync()
+        public async Task MustGetSingleZipCodeObjectAsync()
         {
             var actual = await _service.GetAddressAsync<List<SmartyStreetsModel>>(ZipCodeTest);
 
@@ -178,7 +177,7 @@ public async void MustGetSingleZipCodeObjectAsync()
         }
 
         [Fact]
-        public async void MustGetZipCodeByParamsListAsync()
+        public async Task MustGetZipCodeByParamsListAsync()
         {
             var actual = await _serviceParam.ListAddressesAsync<SmartyStreetsParamsModel>(SmartyStreetsParameterState, SmartyStreetsParameterCity, SmartyStreetsParameterStreet);