Fix crash in case conversion helpers. (#119)

Resolves #118.

Author: alexzherdev

lib/helpers.js

@@ -60,29 +60,38 @@ const isPlainObject = (val) => !!val && typeof val === 'object' && val.construct
 const transform = (obj, fn, acc) => Object.keys(obj).reduce((a, k) => fn(a, obj[k], k, obj), acc);
 
 // https://github.com/30-seconds/30-seconds-of-code/blob/master/snippets/toKebabCase.md
-const toKebabCase = (str) =>
-  str &&
-  str
-    .match(/[A-Z]{2,}(?=[A-Z][a-z]+[0-9]*|\b)|[A-Z]?[a-z]+[0-9]*|[A-Z]|[0-9]+/g)
-    .map((x) => x.toLowerCase())
-    .join('-');
+const toKebabCase = (str) => {
+  const match =
+    str && str.match(/[A-Z]{2,}(?=[A-Z][a-z]+[0-9]*|\b)|[A-Z]?[a-z]+[0-9]*|[A-Z]|[0-9]+/g);
 
+  if (!match) {
+    return str;
+  }
+
+  return match.map((x) => x.toLowerCase()).join('-');
+};
 // https://github.com/30-seconds/30-seconds-of-code/blob/master/snippets/toSnakeCase.md
-const toSnakeCase = (str) =>
-  str &&
-  str
-    .match(/[A-Z]{2,}(?=[A-Z][a-z]+[0-9]*|\b)|[A-Z]?[a-z]+[0-9]*|[A-Z]|[0-9]+/g)
-    .map((x) => x.toLowerCase())
-    .join('_');
+const toSnakeCase = (str) => {
+  const match =
+    str && str.match(/[A-Z]{2,}(?=[A-Z][a-z]+[0-9]*|\b)|[A-Z]?[a-z]+[0-9]*|[A-Z]|[0-9]+/g);
+
+  if (!match) {
+    return str;
+  }
+
+  return match.map((x) => x.toLowerCase()).join('_');
+};
 
 // https://github.com/30-seconds/30-seconds-of-code/blob/master/snippets/toCamelCase.md
 const toCamelCase = (str) => {
-  const s =
-    str &&
-    str
-      .match(/[A-Z]{2,}(?=[A-Z][a-z]+[0-9]*|\b)|[A-Z]?[a-z]+[0-9]*|[A-Z]|[0-9]+/g)
-      .map((x) => x.slice(0, 1).toUpperCase() + x.slice(1).toLowerCase())
-      .join('');
+  const match =
+    str && str.match(/[A-Z]{2,}(?=[A-Z][a-z]+[0-9]*|\b)|[A-Z]?[a-z]+[0-9]*|[A-Z]|[0-9]+/g);
+
+  if (!match) {
+    return str;
+  }
+
+  const s = match.map((x) => x.slice(0, 1).toUpperCase() + x.slice(1).toLowerCase()).join('');
   return s.slice(0, 1).toLowerCase() + s.slice(1);
 };
 

test/unit/helpers.test.js

@@ -1,35 +1,55 @@
 const { expect } = require('chai');
 
-const { set } = require('../../lib/helpers');
+const { set, toCamelCase, toSnakeCase, toKebabCase } = require('../../lib/helpers');
 
 describe('Helpers', () => {
-  it('should do nothing if it is not an object', () => {
-    const object = 1;
-    set(object, 'exist', true);
-    expect(object).to.equal(1);
-  });
+  describe('set', () => {
+    it('should do nothing if it is not an object', () => {
+      const object = 1;
+      set(object, 'exist', true);
+      expect(object).to.equal(1);
+    });
 
-  it('should set a value by path', () => {
-    const object = { exist: {} };
-    set(object, 'exist', true);
-    set(object, 'a[0].b.c', 4);
-    set(object, ['x', '0', 'y', 'z'], 5);
-    expect(object).to.deep.equal({
-      exist: true,
-      a: [
-        {
-          b: {
-            c: 4,
+    it('should set a value by path', () => {
+      const object = { exist: {} };
+      set(object, 'exist', true);
+      set(object, 'a[0].b.c', 4);
+      set(object, ['x', '0', 'y', 'z'], 5);
+      expect(object).to.deep.equal({
+        exist: true,
+        a: [
+          {
+            b: {
+              c: 4,
+            },
           },
-        },
-      ],
-      x: [
-        {
-          y: {
-            z: 5,
+        ],
+        x: [
+          {
+            y: {
+              z: 5,
+            },
           },
-        },
-      ],
+        ],
+      });
+    });
+  });
+
+  describe('toCamelCase', () => {
+    it('should not choke on non-alpha characters', () => {
+      expect(toCamelCase('*')).to.equal('*');
+    });
+  });
+
+  describe('toSnakeCase', () => {
+    it('should not choke on non-alphanumeric characters', () => {
+      expect(toSnakeCase('*')).to.equal('*');
+    });
+  });
+
+  describe('toKebabCase', () => {
+    it('should not choke on non-alphanumeric characters', () => {
+      expect(toKebabCase('*')).to.equal('*');
     });
   });
 });