forked from open-feature/python-sdk
-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathtest_client.py
More file actions
668 lines (566 loc) · 20.2 KB
/
test_client.py
File metadata and controls
668 lines (566 loc) · 20.2 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
import inspect
import time
import types
import uuid
from concurrent.futures import ThreadPoolExecutor
from unittest.mock import MagicMock
import pytest
from openfeature import api
from openfeature.api import (
add_hooks,
clear_hooks,
get_client,
set_evaluation_context,
set_provider,
set_transaction_context,
)
from openfeature.client import OpenFeatureClient, _typecheck_flag_value
from openfeature.evaluation_context import EvaluationContext
from openfeature.event import EventDetails, ProviderEvent, ProviderEventDetails
from openfeature.exception import ErrorCode, OpenFeatureError
from openfeature.flag_evaluation import FlagResolutionDetails, FlagType, Reason
from openfeature.hook import Hook
from openfeature.provider import FeatureProvider, ProviderStatus
from openfeature.provider.in_memory_provider import InMemoryFlag, InMemoryProvider
from openfeature.provider.no_op_provider import NoOpProvider
from openfeature.transaction_context import ContextVarsTransactionContextPropagator
@pytest.mark.parametrize(
"flag_type, default_value, get_method",
(
(bool, True, "get_boolean_value"),
(bool, True, "get_boolean_value_async"),
(str, "String", "get_string_value"),
(str, "String", "get_string_value_async"),
(int, 100, "get_integer_value"),
(int, 100, "get_integer_value_async"),
(float, 10.23, "get_float_value"),
(float, 10.23, "get_float_value_async"),
(
dict,
{
"String": "string",
"Number": 2,
"Boolean": True,
},
"get_object_value",
),
(
dict,
{
"String": "string",
"Number": 2,
"Boolean": True,
},
"get_object_value_async",
),
(
list,
["string1", "string2"],
"get_object_value",
),
(
list,
["string1", "string2"],
"get_object_value_async",
),
),
)
@pytest.mark.asyncio
async def test_should_get_flag_value_based_on_method_type(
flag_type, default_value, get_method, no_op_provider_client
):
# Given
# When
method = getattr(no_op_provider_client, get_method)
if inspect.iscoroutinefunction(method):
flag = await method(flag_key="Key", default_value=default_value)
else:
flag = method(flag_key="Key", default_value=default_value)
# Then
assert flag is not None
assert flag == default_value
assert isinstance(flag, flag_type)
@pytest.mark.parametrize(
"flag_type, default_value, get_method",
(
(bool, True, "get_boolean_details"),
(bool, True, "get_boolean_details_async"),
(str, "String", "get_string_details"),
(str, "String", "get_string_details_async"),
(int, 100, "get_integer_details"),
(int, 100, "get_integer_details_async"),
(float, 10.23, "get_float_details"),
(float, 10.23, "get_float_details_async"),
(
dict,
{
"String": "string",
"Number": 2,
"Boolean": True,
},
"get_object_details",
),
(
dict,
{
"String": "string",
"Number": 2,
"Boolean": True,
},
"get_object_details_async",
),
(
list,
["string1", "string2"],
"get_object_details",
),
(
list,
["string1", "string2"],
"get_object_details_async",
),
),
)
@pytest.mark.asyncio
async def test_should_get_flag_detail_based_on_method_type(
flag_type, default_value, get_method, no_op_provider_client
):
# Given
# When
method = getattr(no_op_provider_client, get_method)
if inspect.iscoroutinefunction(method):
flag = await method(flag_key="Key", default_value=default_value)
else:
flag = method(flag_key="Key", default_value=default_value)
# Then
assert flag is not None
assert flag.value == default_value
assert isinstance(flag.value, flag_type)
@pytest.mark.asyncio
async def test_should_raise_exception_when_invalid_flag_type_provided(
no_op_provider_client,
):
# Given
# When
flag_sync = no_op_provider_client.evaluate_flag_details(
flag_type=None, flag_key="Key", default_value=True
)
flag_async = await no_op_provider_client.evaluate_flag_details_async(
flag_type=None, flag_key="Key", default_value=True
)
# Then
for flag in [flag_sync, flag_async]:
assert flag.value
assert flag.error_message == "Unknown flag type"
assert flag.error_code == ErrorCode.GENERAL
assert flag.reason == Reason.ERROR
def test_should_pass_flag_metadata_from_resolution_to_evaluation_details():
# Given
provider = InMemoryProvider(
{
"Key": InMemoryFlag(
"true",
{"true": True, "false": False},
flag_metadata={"foo": "bar"},
)
}
)
set_provider(provider, "my-client")
client = OpenFeatureClient("my-client", None)
# When
details = client.get_boolean_details(flag_key="Key", default_value=False)
# Then
assert details is not None
assert details.flag_metadata == {"foo": "bar"}
def test_should_handle_a_generic_exception_thrown_by_a_provider(no_op_provider_client):
# Given
exception_hook = MagicMock(spec=Hook)
exception_hook.after.side_effect = Exception("Generic exception raised")
no_op_provider_client.add_hooks([exception_hook])
# When
flag_details = no_op_provider_client.get_boolean_details(
flag_key="Key", default_value=True
)
# Then
assert flag_details is not None
assert flag_details.value
assert isinstance(flag_details.value, bool)
assert flag_details.reason == Reason.ERROR
assert flag_details.error_message == "Generic exception raised"
def test_should_handle_an_open_feature_exception_thrown_by_a_provider(
no_op_provider_client,
):
# Given
exception_hook = MagicMock(spec=Hook)
exception_hook.after.side_effect = OpenFeatureError(
ErrorCode.GENERAL, "error_message"
)
no_op_provider_client.add_hooks([exception_hook])
# When
flag_details = no_op_provider_client.get_boolean_details(
flag_key="Key", default_value=True
)
# Then
assert flag_details is not None
assert flag_details.value
assert isinstance(flag_details.value, bool)
assert flag_details.reason == Reason.ERROR
assert flag_details.error_message == "error_message"
def test_should_return_client_metadata_with_domain():
# Given
client = OpenFeatureClient("my-client", None, NoOpProvider())
# When
metadata = client.get_metadata()
# Then
assert metadata is not None
assert metadata.domain == "my-client"
def test_should_call_api_level_hooks(no_op_provider_client):
# Given
clear_hooks()
api_hook = MagicMock(spec=Hook)
add_hooks([api_hook])
# When
no_op_provider_client.get_boolean_details(flag_key="Key", default_value=True)
# Then
api_hook.before.assert_called_once()
api_hook.after.assert_called_once()
# Requirement 1.7.1, Requirement 1.7.3
def test_should_define_a_provider_status_accessor(no_op_provider_client):
# When
status = no_op_provider_client.get_provider_status()
# Then
assert status is not None
assert status == ProviderStatus.READY
# Requirement 1.7.4
def test_provider_should_return_error_status_if_failed():
# Given
provider = NoOpProvider()
set_provider(provider)
client = get_client()
provider.emit_provider_error(ProviderEventDetails(error_code=ErrorCode.GENERAL))
# When
status = client.get_provider_status()
# Then
assert status == ProviderStatus.ERROR
# Requirement 1.7.6, Requirement 1.7.8
@pytest.mark.asyncio
async def test_should_shortcircuit_if_provider_is_not_ready(
no_op_provider_client, monkeypatch
):
# Given
monkeypatch.setattr(
no_op_provider_client, "get_provider_status", lambda: ProviderStatus.NOT_READY
)
spy_hook = MagicMock(spec=Hook)
no_op_provider_client.add_hooks([spy_hook])
# When
flag_details_sync = no_op_provider_client.get_boolean_details(
flag_key="Key", default_value=True
)
spy_hook.error.assert_called_once()
spy_hook.reset_mock()
flag_details_async = await no_op_provider_client.get_boolean_details_async(
flag_key="Key", default_value=True
)
# Then
for flag_details in [flag_details_sync, flag_details_async]:
assert flag_details is not None
assert flag_details.value
assert flag_details.reason == Reason.ERROR
assert flag_details.error_code == ErrorCode.PROVIDER_NOT_READY
spy_hook.error.assert_called_once()
spy_hook.finally_after.assert_called_once()
# Requirement 1.7.5, Requirement 1.7.7
@pytest.mark.asyncio
async def test_should_shortcircuit_if_provider_is_in_irrecoverable_error_state(
no_op_provider_client, monkeypatch
):
# Given
monkeypatch.setattr(
no_op_provider_client, "get_provider_status", lambda: ProviderStatus.FATAL
)
spy_hook = MagicMock(spec=Hook)
no_op_provider_client.add_hooks([spy_hook])
# When
flag_details_sync = no_op_provider_client.get_boolean_details(
flag_key="Key", default_value=True
)
spy_hook.error.assert_called_once()
spy_hook.reset_mock()
flag_details_async = await no_op_provider_client.get_boolean_details_async(
flag_key="Key", default_value=True
)
# Then
for flag_details in [flag_details_sync, flag_details_async]:
assert flag_details is not None
assert flag_details.value
assert flag_details.reason == Reason.ERROR
assert flag_details.error_code == ErrorCode.PROVIDER_FATAL
spy_hook.error.assert_called_once()
spy_hook.finally_after.assert_called_once()
# Requirement 1.7.9
def test_provider_should_return_not_ready_status_after_shutdown(monkeypatch):
# Given
provider = NoOpProvider()
set_provider(provider)
client = get_client()
def _shutdown(self) -> None:
self._status = ProviderStatus.NOT_READY
monkeypatch.setattr(provider, "shutdown", types.MethodType(_shutdown, provider))
# When
api.shutdown()
status = client.get_provider_status()
# Then
assert status == ProviderStatus.NOT_READY
@pytest.mark.asyncio
async def test_should_run_error_hooks_if_provider_returns_resolution_with_error_code():
# Given
spy_hook = MagicMock(spec=Hook)
provider = MagicMock(spec=FeatureProvider)
provider.get_provider_hooks.return_value = []
mock_resolution = FlagResolutionDetails(
value=True,
reason=Reason.ERROR,
error_code=ErrorCode.PROVIDER_FATAL,
error_message="This is an error message",
)
provider.resolve_boolean_details.return_value = mock_resolution
provider.resolve_boolean_details_async.return_value = mock_resolution
set_provider(provider)
client = get_client()
client.add_hooks([spy_hook])
# When
flag_details_sync = client.get_boolean_details(flag_key="Key", default_value=True)
spy_hook.error.assert_called_once()
spy_hook.reset_mock()
flag_details_async = await client.get_boolean_details_async(
flag_key="Key", default_value=True
)
# Then
for flag_details in [flag_details_sync, flag_details_async]:
assert flag_details is not None
assert flag_details.value
assert flag_details.reason == Reason.ERROR
assert flag_details.error_code == ErrorCode.PROVIDER_FATAL
spy_hook.error.assert_called_once()
@pytest.mark.asyncio
async def test_client_type_mismatch_exceptions():
# Given
client = get_client()
# When
flag_details_sync = client.get_boolean_details(
flag_key="Key", default_value="type mismatch"
)
flag_details_async = await client.get_boolean_details_async(
flag_key="Key", default_value="type mismatch"
)
# Then
for flag_details in [flag_details_sync, flag_details_async]:
assert flag_details is not None
assert flag_details.value
assert flag_details.reason == Reason.ERROR
assert flag_details.error_code == ErrorCode.TYPE_MISMATCH
@pytest.mark.asyncio
async def test_typecheck_flag_value_general_error():
# Given
flag_value = "A"
flag_type = None
# When
err = _typecheck_flag_value(value=flag_value, flag_type=flag_type)
# Then
assert err.error_code == ErrorCode.GENERAL
assert err.error_message == "Unknown flag type"
@pytest.mark.asyncio
async def test_typecheck_flag_value_type_mismatch_error():
# Given
flag_value = "A"
flag_type = FlagType.BOOLEAN
# When
err = _typecheck_flag_value(value=flag_value, flag_type=flag_type)
# Then
assert err.error_code == ErrorCode.TYPE_MISMATCH
assert err.error_message == "Expected type <class 'bool'> but got <class 'str'>"
def test_provider_events():
# Given
provider = NoOpProvider()
set_provider(provider)
other_provider = NoOpProvider()
set_provider(other_provider, "my-domain")
provider_details = ProviderEventDetails(message="message")
details = EventDetails.from_provider_event_details(
provider.get_metadata().name, provider_details
)
def emit_all_events(provider):
provider.emit_provider_configuration_changed(provider_details)
provider.emit_provider_error(provider_details)
provider.emit_provider_stale(provider_details)
spy = MagicMock()
client = get_client()
client.add_handler(ProviderEvent.PROVIDER_READY, spy.provider_ready)
client.add_handler(
ProviderEvent.PROVIDER_CONFIGURATION_CHANGED, spy.provider_configuration_changed
)
client.add_handler(ProviderEvent.PROVIDER_ERROR, spy.provider_error)
client.add_handler(ProviderEvent.PROVIDER_STALE, spy.provider_stale)
# When
emit_all_events(provider)
emit_all_events(other_provider)
# Then
# NOTE: provider_ready is called immediately after adding the handler
spy.provider_ready.assert_called_once()
spy.provider_configuration_changed.assert_called_once_with(details)
spy.provider_error.assert_called_once_with(details)
spy.provider_stale.assert_called_once_with(details)
def test_add_remove_event_handler():
# Given
provider = NoOpProvider()
set_provider(provider)
spy = MagicMock()
client = get_client()
client.add_handler(
ProviderEvent.PROVIDER_CONFIGURATION_CHANGED, spy.provider_configuration_changed
)
client.remove_handler(
ProviderEvent.PROVIDER_CONFIGURATION_CHANGED, spy.provider_configuration_changed
)
provider_details = ProviderEventDetails(message="message")
# When
provider.emit_provider_configuration_changed(provider_details)
# Then
spy.provider_configuration_changed.assert_not_called()
# Requirement 5.1.2, Requirement 5.1.3
def test_provider_event_late_binding():
# Given
provider = NoOpProvider()
set_provider(provider, "my-domain")
other_provider = NoOpProvider()
spy = MagicMock()
client = get_client("my-domain")
client.add_handler(
ProviderEvent.PROVIDER_CONFIGURATION_CHANGED, spy.provider_configuration_changed
)
set_provider(other_provider, "my-domain")
provider_details = ProviderEventDetails(message="message from provider")
other_provider_details = ProviderEventDetails(message="message from other provider")
details = EventDetails.from_provider_event_details(
other_provider.get_metadata().name, other_provider_details
)
# When
provider.emit_provider_configuration_changed(provider_details)
other_provider.emit_provider_configuration_changed(other_provider_details)
# Then
spy.provider_configuration_changed.assert_called_once_with(details)
# Requirement 5.1.4, Requirement 5.1.5
def test_provider_event_handler_exception():
# Given
provider = NoOpProvider()
set_provider(provider)
spy = MagicMock()
client = get_client()
client.add_handler(ProviderEvent.PROVIDER_ERROR, spy.provider_error)
# When
provider.emit_provider_error(
ProviderEventDetails(error_code=ErrorCode.GENERAL, message="some_error")
)
# Then
spy.provider_error.assert_called_once_with(
EventDetails(
flags_changed=None,
message="some_error",
error_code=ErrorCode.GENERAL,
metadata={},
provider_name="No-op Provider",
)
)
def test_client_handlers_thread_safety():
provider = NoOpProvider()
set_provider(provider)
def add_handlers_task():
def handler(*args, **kwargs):
time.sleep(0.005)
for _ in range(10):
time.sleep(0.01)
client = get_client(str(uuid.uuid4()))
client.add_handler(ProviderEvent.PROVIDER_CONFIGURATION_CHANGED, handler)
def emit_events_task():
for _ in range(10):
time.sleep(0.01)
provider.emit_provider_configuration_changed(ProviderEventDetails())
with ThreadPoolExecutor(max_workers=2) as executor:
f1 = executor.submit(add_handlers_task)
f2 = executor.submit(emit_events_task)
f1.result()
f2.result()
def test_client_should_merge_contexts():
api.clear_hooks()
api.set_transaction_context_propagator(ContextVarsTransactionContextPropagator())
provider = NoOpProvider()
provider.resolve_boolean_details = MagicMock(wraps=provider.resolve_boolean_details)
api.set_provider(provider)
# Global evaluation context
global_context = EvaluationContext(
targeting_key="global", attributes={"global_attr": "global_value"}
)
api.set_evaluation_context(global_context)
# Transaction context
transaction_context = EvaluationContext(
targeting_key="transaction",
attributes={"transaction_attr": "transaction_value"},
)
api.set_transaction_context(transaction_context)
# Client-specific context
client_context = EvaluationContext(
targeting_key="client", attributes={"client_attr": "client_value"}
)
client = OpenFeatureClient(domain=None, version=None, context=client_context)
# Invocation-specific context
invocation_context = EvaluationContext(
targeting_key="invocation", attributes={"invocation_attr": "invocation_value"}
)
flag_input = "flag"
flag_default = False
client.get_boolean_details(flag_input, flag_default, invocation_context)
# Retrieve the call arguments
_, kwargs = provider.resolve_boolean_details.call_args
flag_key, default_value, context = (
kwargs["flag_key"],
kwargs["default_value"],
kwargs["evaluation_context"],
)
assert flag_key == flag_input
assert default_value is flag_default
assert context.targeting_key == "invocation" # Last one in the merge chain
assert context.attributes["global_attr"] == "global_value"
assert context.attributes["transaction_attr"] == "transaction_value"
assert context.attributes["client_attr"] == "client_value"
assert context.attributes["invocation_attr"] == "invocation_value"
def test_client_should_track_event():
spy_provider = MagicMock(spec=NoOpProvider)
set_provider(spy_provider)
client = get_client()
client.track(tracking_event_name="test")
spy_provider.track.assert_called_once()
def test_tracking_merges_evaluation_contexts():
spy_provider = MagicMock(spec=NoOpProvider)
api.set_provider(spy_provider)
client = get_client()
set_evaluation_context(EvaluationContext("id", attributes={"key": "eval_value"}))
set_transaction_context(
EvaluationContext("id", attributes={"transaction_attr": "transaction_value"})
)
client.track(
tracking_event_name="test",
evaluation_context=EvaluationContext("id", attributes={"key": "value"}),
)
spy_provider.track.assert_called_once_with(
"test",
EvaluationContext(
"id", attributes={"transaction_attr": "transaction_value", "key": "value"}
),
None,
)
def test_should_noop_if_provider_does_not_support_tracking(monkeypatch):
provider = NoOpProvider()
set_provider(provider)
client = get_client()
client.track(tracking_event_name="test")