cleanups

Author: danlapid

packages/dynamic-worker-bundler/src/installer.ts

@@ -41,11 +41,6 @@ interface InstallOptions {
    * Registry URL (default: https://registry.npmjs.org)
    */
   registry?: string;
-
-  /**
-   * Called when a package is being installed
-   */
-  onProgress?: (message: string) => void;
 }
 
 interface InstallResult {
@@ -79,7 +74,7 @@ export async function installDependencies(
   files: Files,
   options: InstallOptions = {}
 ): Promise<InstallResult> {
-  const { dev = false, registry = NPM_REGISTRY, onProgress } = options;
+  const { dev = false, registry = NPM_REGISTRY } = options;
 
   const result: InstallResult = {
     files: { ...files },
@@ -119,15 +114,7 @@ export async function installDependencies(
   // Install all dependencies in parallel
   await Promise.all(
     Object.entries(depsToInstall).map(([name, versionRange]) =>
-      installPackage(
-        name,
-        versionRange,
-        result,
-        installedPackages,
-        inProgress,
-        registry,
-        onProgress
-      )
+      installPackage(name, versionRange, result, installedPackages, inProgress, registry)
     )
   );
 
@@ -143,8 +130,7 @@ async function installPackage(
   result: InstallResult,
   installedPackages: Map<string, string>,
   inProgress: Map<string, Promise<void>>,
-  registry: string,
-  onProgress?: (message: string) => void
+  registry: string
 ): Promise<void> {
   // Skip if already installed
   if (installedPackages.has(name)) {
@@ -193,15 +179,7 @@ async function installPackage(
       const deps = versionMetadata.dependencies ?? {};
       await Promise.all(
         Object.entries(deps).map(([depName, depVersion]) =>
-          installPackage(
-            depName,
-            depVersion,
-            result,
-            installedPackages,
-            inProgress,
-            registry,
-            onProgress
-          )
+          installPackage(depName, depVersion, result, installedPackages, inProgress, registry)
         )
       );
     } catch (error) {

packages/tests/src/installer.test.ts

@@ -1,8 +1,8 @@
+import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
 import {
   hasDependencies,
   installDependencies,
 } from '../../dynamic-worker-bundler/src/installer.js';
-import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
 
 /**
  * Create a minimal tar archive with the given files.
@@ -35,7 +35,7 @@ function createTarball(files: Record<string, string>): Uint8Array {
 
     // Size (124-135) - octal, 11 chars + null
     const sizeOctal = contentBytes.length.toString(8).padStart(11, '0');
-    header.set(encoder.encode(sizeOctal + '\0'), 124);
+    header.set(encoder.encode(`${sizeOctal}\0`), 124);
 
     // Mtime (136-147) - "00000000000\0"
     header.set(encoder.encode('00000000000\0'), 136);
@@ -49,10 +49,10 @@ function createTarball(files: Record<string, string>): Uint8Array {
     // Calculate checksum (sum of all bytes, treating checksum field as spaces)
     let checksum = 0;
     for (let i = 0; i < 512; i++) {
-      checksum += header[i]!;
+      checksum += header[i] ?? 0;
     }
     const checksumOctal = checksum.toString(8).padStart(6, '0');
-    header.set(encoder.encode(checksumOctal + '\0 '), 148);
+    header.set(encoder.encode(`${checksumOctal}\0 `), 148);
 
     blocks.push(header);