ValueFlow: pass SymbolDatabase by reference into ValueFlow::setValues() (#5295)

Author: firewave

lib/cppcheck.cpp

@@ -545,7 +545,7 @@ unsigned int CppCheck::check(const std::string &path)
             tokenizer.list.appendFileIfNew(path);
             clangimport::parseClangAstDump(&tokenizer, ast);
             ValueFlow::setValues(tokenizer.list,
-                                 const_cast<SymbolDatabase*>(tokenizer.getSymbolDatabase()),
+                                 const_cast<SymbolDatabase&>(*tokenizer.getSymbolDatabase()),
                                  this,
                                  &mSettings,
                                  &s_timerResults);

lib/tokenize.cpp

@@ -3361,9 +3361,9 @@ bool Tokenizer::simplifyTokens1(const std::string &configuration)
     if (doValueFlow) {
         if (mTimerResults) {
             Timer t("Tokenizer::simplifyTokens1::ValueFlow", mSettings->showtime, mTimerResults);
-            ValueFlow::setValues(list, mSymbolDatabase, mErrorLogger, mSettings, mTimerResults);
+            ValueFlow::setValues(list, *mSymbolDatabase, mErrorLogger, mSettings, mTimerResults);
         } else {
-            ValueFlow::setValues(list, mSymbolDatabase, mErrorLogger, mSettings, mTimerResults);
+            ValueFlow::setValues(list, *mSymbolDatabase, mErrorLogger, mSettings, mTimerResults);
         }
     }